Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include the PhotoGallery page #15

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

IsaiahA21
Copy link

No description provided.

@IsaiahA21 IsaiahA21 requested a review from a team as a code owner November 30, 2024 01:39
Copy link

vercel bot commented Nov 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 1:17am

@IsaiahA21 IsaiahA21 changed the title included the PhotoGallery page include the PhotoGallery page Nov 30, 2024
@IsaiahA21 IsaiahA21 linked an issue Nov 30, 2024 that may be closed by this pull request
@Anidion
Copy link
Contributor

Anidion commented Dec 11, 2024

yarn build is failing, please resolve then I can take a look.
Also, it doesn't look formatted, please run linting and formatting

src/pageLayouts/GalleryPage.styles.ts Outdated Show resolved Hide resolved
src/components/PhotoGallery/PhotoGallery.tsx Outdated Show resolved Hide resolved
@IsaiahA21
Copy link
Author

@IsaiahA21 IsaiahA21 closed this Jan 9, 2025
@IsaiahA21
Copy link
Author

yarn build is failing, please resolve then I can take a look. Also, it doesn't look formatted, please run linting and formatting

./src/pages/gallery/index.tsx
5:63 Error: Replace ·req:·_req,·res· with ␍⏎··req:·_req,␍⏎··res,␍⏎ prettier/prettier

Ive tried resolving the yarn build error by running yarn prettier --write ./src/pages/api/gallery.js but it doesn't resolve it

@IsaiahA21 IsaiahA21 reopened this Jan 9, 2025
@IsaiahA21 IsaiahA21 requested a review from Anidion January 17, 2025 01:35
@IsaiahA21 IsaiahA21 dismissed Anidion’s stale review January 17, 2025 01:37

cause I think I have resolved it

@IsaiahA21
Copy link
Author

Jan 16th update: yarn build is successful but 1 of the 3 GitHub checks is blocking merge. I need to access the club's Vercel account to get more detail about the issue.
"Vercel -- Deployment has failed"

Result of yarn build
image

@brian-ngyn
Copy link
Member

@IsaiahA21 Can you try to cherrypick f40a53e into your branch and see if it fixes the vercel build?

transition={{ delay: 0.5 }}
>
<div className="text-center">
<p className="text-babyHeading-size·text-white·sm-max:text-regular-font">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure why the color is not white and but black(defualt) instead

import { GetServerSideProps } from "next";

export const getServerSideProps: GetServerSideProps = async ({
req: _req,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a good idea to use getStaticProp instead of getServerSideProp? I say this because the photoalbum is infrequently updated so getting the images once and serving it each time would make sense to me than retrieving it on every request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Gallery Page
3 participants