Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests. #111

Open
2e0byo opened this issue May 1, 2023 · 3 comments
Open

Add integration tests. #111

2e0byo opened this issue May 1, 2023 · 3 comments
Assignees

Comments

@2e0byo
Copy link
Collaborator

2e0byo commented May 1, 2023

Apparently

Deprecated field ‘track’ with the goal of removing it in the next major release, use ‘track_name’ instead. Backends should support both track and track_name until they require a version of Mopidy where track has been removed. src

I don't know if we do this, but I do know that we don't have a test for it. We need integration tests, preferably against a few versions of mopidy, with -Werror so we fail on deprecations.

@tehkillerbee this would be slightly easier to write (at least for me) if we were using poetry. If you'd be up for that I'll do it in the PR. But I'm perfectly happy to figure out how to do it without.

[Edit] I can't self-assign so adding here that I obv intend to write these myself unless anyone else wants to. Opening this issue just to keep track/allow conversation before the PR lands.

@tehkillerbee
Copy link
Owner

tehkillerbee commented May 1, 2023

@2e0byo I am not familiar with poetry and I have no preferences so feel free to use it

FYI I have added both you and @blacklight as collaborators, as it might make it a little more efficient as it should allow you to assign issues to yourself. Feel free to accept if you want.

@2e0byo
Copy link
Collaborator Author

2e0byo commented May 1, 2023

Ta! I promise not to do anything stupid. Well, not intentionally anyhow ;)

@2e0byo
Copy link
Collaborator Author

2e0byo commented May 7, 2023

Curiously having re-read mopidy code I don't think there is any way to trigger this deprecation warning, since we've overriden the method. I'm just going to fix it for now, but integration tests are on the way anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants