Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get mypy passing #112

Open
2e0byo opened this issue May 7, 2023 · 0 comments
Open

Get mypy passing #112

2e0byo opened this issue May 7, 2023 · 0 comments
Assignees

Comments

@2e0byo
Copy link
Collaborator

2e0byo commented May 7, 2023

We have at least one type error; get_distinct should return a set, not a list. (Clearly none of the distinct set api is being used.) Mypy doesn't currently run, and won't until we have types for tidalapi. So to get mypy passing we need to add type hints to tidalapi (we can use a stub for now so no need to wait on tidalapi), and fix some internal problems. I'd love to know, for instance, why self.backend is thought not to have a .session.

As an added benefit modern IDEs will be better at auto-completing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant