You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have at least one type error; get_distinct should return a set, not a list. (Clearly none of the distinct set api is being used.) Mypy doesn't currently run, and won't until we have types for tidalapi. So to get mypy passing we need to add type hints to tidalapi (we can use a stub for now so no need to wait on tidalapi), and fix some internal problems. I'd love to know, for instance, why self.backend is thought not to have a .session.
As an added benefit modern IDEs will be better at auto-completing.
The text was updated successfully, but these errors were encountered:
We have at least one type error;
get_distinct
should return a set, not a list. (Clearly none of the distinct set api is being used.) Mypy doesn't currently run, and won't until we have types for tidalapi. So to get mypy passing we need to add type hints to tidalapi (we can use a stub for now so no need to wait on tidalapi), and fix some internal problems. I'd love to know, for instance, whyself.backend
is thought not to have a.session
.As an added benefit modern IDEs will be better at auto-completing.
The text was updated successfully, but these errors were encountered: