Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing quality log messages #163

Closed
fmarzocca opened this issue Mar 19, 2024 · 3 comments
Closed

Fix confusing quality log messages #163

fmarzocca opened this issue Mar 19, 2024 · 3 comments

Comments

@fmarzocca
Copy link

fmarzocca commented Mar 19, 2024

I was looking at the log and found these lines:

Mar 19 16:58:17 pab mopidy[2154]: INFO     [TidalBackend-3 (_actor_loop)] mopidy_tidal.playback No HI_RES available for this track; Using playback quality: LOSSLESS
Mar 19 16:58:17 pab mopidy[2154]: INFO     [TidalBackend-3 (_actor_loop)] mopidy_tidal.playback Starting playback of track:96830423, (quality:HI_RES, codec:MQA, 16bit/44100Hz)

The first one states quality is LOSSLESS, the second reports quality as HI_RES...
Which one is right?
I checked with tidalapi and it reports HI_RES for this track.

@tehkillerbee
Copy link
Owner

This message refers to the fact that you requested HI_RES audio as the tidal quality but it was not listed/available in the metadata for that track. But now that we use the stream to get the quality, we should probably use that instead.

The actual quality used for playback will always be listed in the following log message: "Starting playback of track:96830423, (quality:HI_RES, codec:MQA, 16bit/44100Hz)"

FYI, if you want lossless quality, you should use HI_RES_LOSSLESS but maybe you prefer to use MQA instead?

@tehkillerbee tehkillerbee changed the title Quality in log Fix confusing quality log messages Mar 19, 2024
@fmarzocca
Copy link
Author

fmarzocca commented Mar 19, 2024

FYI, if you want lossless quality, you should use HI_RES_LOSSLESS but maybe you prefer to use MQA instead?

I have set HI_RES_LOSSLESS in mopidy.conf, but I believe the quality is defined by the specific playing track.

@tehkillerbee
Copy link
Owner

Closing, as this issue does not exist when MQA has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants