Skip to content

Commit ab126d2

Browse files
committed
Fix pronoun in command usage text
This commit corrects a grammar error in the warning message shown for experimental commands. The warning previously used "it's" but should use "its" (the possessive pronoun) when referring to the command's usage and behavior.
1 parent 3d29463 commit ab126d2

File tree

6 files changed

+13
-13
lines changed

6 files changed

+13
-13
lines changed

pkg/cli/prerun/prerun.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func PersistentPreRunE(p cli.Params) func(*cobra.Command, []string) error {
1919

2020
func WarnExperimental(cmd *cobra.Command) error {
2121
if IsExperimental(cmd) {
22-
fmt.Fprintf(cmd.OutOrStderr(), "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\n")
22+
fmt.Fprintf(cmd.OutOrStderr(), "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\n")
2323
}
2424
return nil
2525
}

pkg/cmd/bundle/list_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,34 +48,34 @@ func TestListCommand(t *testing.T) {
4848
{
4949
name: "no-format",
5050
format: "",
51-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
51+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
5252
}, {
5353
name: "name-format",
5454
format: "name",
55-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
55+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
5656
}, {
5757
name: "yaml-format",
5858
format: "yaml",
59-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\n" + examplePullPipeline + "---\n" + examplePullTask,
59+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\n" + examplePullPipeline + "---\n" + examplePullTask,
6060
}, {
6161
name: "specify-kind-task",
6262
format: "name",
63-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
63+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
6464
additionalArgs: []string{"Task"},
6565
}, {
6666
name: "specify-kind-task-lowercase-plural",
6767
format: "name",
68-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
68+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
6969
additionalArgs: []string{"tasks"},
7070
}, {
7171
name: "specify-kind-task-lowercase-singular",
7272
format: "name",
73-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
73+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
7474
additionalArgs: []string{"task"},
7575
}, {
7676
name: "specify-kind-pipeline",
7777
format: "name",
78-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
78+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
7979
additionalArgs: []string{"Pipeline"},
8080
}, {
8181
name: "specify-kind-name-dne",
@@ -85,7 +85,7 @@ func TestListCommand(t *testing.T) {
8585
}, {
8686
name: "specify-kind-name",
8787
format: "name",
88-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
88+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
8989
additionalArgs: []string{"Pipeline", "foobar"},
9090
},
9191
}

pkg/cmd/pipeline/sign_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestSign(t *testing.T) {
3838
if err != nil {
3939
t.Errorf("Unexpected error: %v", err)
4040
}
41-
expected := "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nPipeline testdata/pipeline.yaml is signed successfully \n"
41+
expected := "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nPipeline testdata/pipeline.yaml is signed successfully \n"
4242
test.AssertOutput(t, expected, out)
4343

4444
// verify the signed task

pkg/cmd/pipeline/verify_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ func TestVerify(t *testing.T) {
3232
if err != nil {
3333
t.Errorf("Unexpected error: %v", err)
3434
}
35-
expected := "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nPipeline testdata/signed.yaml passes verification \n"
35+
expected := "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nPipeline testdata/signed.yaml passes verification \n"
3636
test.AssertOutput(t, expected, out)
3737
}

pkg/cmd/task/sign_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestSign(t *testing.T) {
3838
if err != nil {
3939
t.Errorf("Unexpected error: %v", err)
4040
}
41-
expected := "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nTask testdata/task.yaml is signed successfully \n"
41+
expected := "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nTask testdata/task.yaml is signed successfully \n"
4242
test.AssertOutput(t, expected, out)
4343

4444
// verify the signed task

pkg/cmd/task/verify_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ func TestVerify(t *testing.T) {
3232
if err != nil {
3333
t.Errorf("Unexpected error: %v", err)
3434
}
35-
expected := "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nTask testdata/signed.yaml passes verification \n"
35+
expected := "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nTask testdata/signed.yaml passes verification \n"
3636
test.AssertOutput(t, expected, out)
3737
}

0 commit comments

Comments
 (0)