You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit corrects a grammar error in the warning message shown
for experimental commands.
The warning previously used "it's" but should use "its" (the possessive
pronoun) when referring to the command's usage and behavior.
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
51
+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
52
52
}, {
53
53
name: "name-format",
54
54
format: "name",
55
-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
55
+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
56
56
}, {
57
57
name: "yaml-format",
58
58
format: "yaml",
59
-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\n"+examplePullPipeline+"---\n"+examplePullTask,
59
+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\n"+examplePullPipeline+"---\n"+examplePullTask,
60
60
}, {
61
61
name: "specify-kind-task",
62
62
format: "name",
63
-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
63
+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
64
64
additionalArgs: []string{"Task"},
65
65
}, {
66
66
name: "specify-kind-task-lowercase-plural",
67
67
format: "name",
68
-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
68
+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
69
69
additionalArgs: []string{"tasks"},
70
70
}, {
71
71
name: "specify-kind-task-lowercase-singular",
72
72
format: "name",
73
-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
73
+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
74
74
additionalArgs: []string{"task"},
75
75
}, {
76
76
name: "specify-kind-pipeline",
77
77
format: "name",
78
-
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
78
+
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
Copy file name to clipboardExpand all lines: pkg/cmd/pipeline/sign_test.go
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -38,7 +38,7 @@ func TestSign(t *testing.T) {
38
38
iferr!=nil {
39
39
t.Errorf("Unexpected error: %v", err)
40
40
}
41
-
expected:="*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nPipeline testdata/pipeline.yaml is signed successfully \n"
41
+
expected:="*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nPipeline testdata/pipeline.yaml is signed successfully \n"
Copy file name to clipboardExpand all lines: pkg/cmd/pipeline/verify_test.go
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -32,6 +32,6 @@ func TestVerify(t *testing.T) {
32
32
iferr!=nil {
33
33
t.Errorf("Unexpected error: %v", err)
34
34
}
35
-
expected:="*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nPipeline testdata/signed.yaml passes verification \n"
35
+
expected:="*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nPipeline testdata/signed.yaml passes verification \n"
Copy file name to clipboardExpand all lines: pkg/cmd/task/sign_test.go
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -38,7 +38,7 @@ func TestSign(t *testing.T) {
38
38
iferr!=nil {
39
39
t.Errorf("Unexpected error: %v", err)
40
40
}
41
-
expected:="*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nTask testdata/task.yaml is signed successfully \n"
41
+
expected:="*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nTask testdata/task.yaml is signed successfully \n"
Copy file name to clipboardExpand all lines: pkg/cmd/task/verify_test.go
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -32,6 +32,6 @@ func TestVerify(t *testing.T) {
32
32
iferr!=nil {
33
33
t.Errorf("Unexpected error: %v", err)
34
34
}
35
-
expected:="*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nTask testdata/signed.yaml passes verification \n"
35
+
expected:="*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nTask testdata/signed.yaml passes verification \n"
0 commit comments