-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to build, opus not found with pkg-config #26414
Comments
I executed the script multiple times and it finally exited without error. Now I got another problem
|
Given that tdesktop can't find Qt, I'm highly doubt it exited without error. |
@ilya-fedin It succeed and the Qt5 library is compiled. And when I execute the prepare script again it prompts no error, everything is done already.
|
provide your CMakeCache.txt |
@ilya-fedin I'll come back ASAP, I have deleted everything and start over again. |
Qt5Config.cmake is located in the Qt-5.5.19 folder And I tried to specify the directory directly, still won't work
Attached CMakeCache.txt |
|
@ilya-fedin Interesting pitfall, can you update the build document and tell other people not to uncheck cmake in Visual Studio Installer? |
Well, it's more a question for @john-preston whether he would like to document that |
Fix issues mentioned here telegramdesktop#26414
I've created a PR for this #26424 |
@ilya-fedin It does not solve the problem .... it still couldn't find QT |
I hope you've cleared the build directory and didn't pass the |
Is it possible you somehow launch prepare.py with x64 build tools but tdesktop itself with x86 build tools? |
According to your CMakeCache.txt, it's not just x86 build tools but x64_x86 cross tools (not x64 Native Tools as the instructions says)
|
If prepare.py was running using x64_x86 cross tools as well then all the built dependencies are corrupted |
I don't remember if it's a X64 native environment, I've deleted |
@ilya-fedin In the x64 Native environment, prepare.py finished successfully and I instantly started the configure.bat, and it fails with the same error Attached cmakecache |
You're still using |
@ilya-fedin Hmm, that's weird, see the last screenshot title .... I'm in the x64 Native tools. What do you think is wrong? I cleared Libraries, ThirdParty and tdesktop\out, is that not enough? |
I'll clear everything and try the x86 steps, just to see if it works |
cmakecache is in out, so I was talking about out specifically.
Are you sure? CMakeCache says you're not. |
Running command line as admin has tendency to reset environment variable, ensure you're not running as admin |
I successfully build it with x86 environment. Weird, not sure what's wrong with x64. |
Have you seen my last message? |
@ilya-fedin Yes I saw it, but I think -D is not actually the culprit. In the x86 environment I forget to use these parameters as well, but it prompts the API and HASH is required, instead of missing QT libraries .... |
Huh? I don't talk about the |
@ilya-fedin Ahhh, damn, I completely missed the |
Is there any way for prepare.py or configure.bat to detect the build environment automatically? Since everything is tied together, I don't think people would mix the environment for different architectures. |
Closing the case. I've successfully build on both x86 and x64 environment. Thanks for the help! @ilya-fedin |
Steps to reproduce
I'm following exactly the steps here
https://github.com/telegramdesktop/tdesktop/blob/dev/docs/building-win-x64.md
Expected behaviour
I expect tdesktop\Telegram\build\prepare\win.bat to finish successfully
Actual behaviour
The prepare script failed
Operating system
Windows Server 2022
Version of Telegram Desktop
latest
Installation source
Other (unofficial) source
Crash ID
No response
Logs
The text was updated successfully, but these errors were encountered: