From 8fac3c134b575ff8ea4fdf415f2ba60591d27b19 Mon Sep 17 00:00:00 2001
From: felixw <felix.weber@iconstorm.com>
Date: Thu, 16 Nov 2023 09:18:26 +0100
Subject: [PATCH 1/4] fix: logo only focusable if href provided

---
 .../src/components/telekom/telekom-header/telekom-header.tsx     | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/components/src/components/telekom/telekom-header/telekom-header.tsx b/packages/components/src/components/telekom/telekom-header/telekom-header.tsx
index f1f6661a87..fedda5217c 100644
--- a/packages/components/src/components/telekom/telekom-header/telekom-header.tsx
+++ b/packages/components/src/components/telekom/telekom-header/telekom-header.tsx
@@ -74,6 +74,7 @@ export class TelekomHeader {
                   part="app-logo"
                   variant="white"
                   href={this.logoHref}
+                  tabindex={this.logoHref ? '0' : '-1'}
                   logoTitle={this.logoTitle}
                   logoHideTitle={this.logoHideTitle}
                 ></scale-logo>

From e1dd447416128a0f130a70aedc26dc6d48f9961a Mon Sep 17 00:00:00 2001
From: felixw <felix.weber@iconstorm.com>
Date: Fri, 24 Nov 2023 15:22:26 +0100
Subject: [PATCH 2/4] fix: logo focus behavior, make footer logo focusable only
 with href

---
 packages/components/src/components/telekom/logo/logo.tsx       | 3 +--
 .../telekom/telekom-footer/telekom-footer-content.tsx          | 3 ++-
 .../src/components/telekom/telekom-header/telekom-header.tsx   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/components/src/components/telekom/logo/logo.tsx b/packages/components/src/components/telekom/logo/logo.tsx
index 5e9abea1b8..eb6717d316 100644
--- a/packages/components/src/components/telekom/logo/logo.tsx
+++ b/packages/components/src/components/telekom/logo/logo.tsx
@@ -87,7 +87,7 @@ export class Logo {
         <a
           href={this.href}
           part={this.getCssClassMap()}
-          tabIndex={this.focusable === false ? -1 : 0}
+          tabindex={this.focusable === false ? '-1' : '0'}
           onFocus={() => {
             if (this.scrollIntoViewOnFocus === true) {
               window.scrollTo({ top: 0 });
@@ -96,7 +96,6 @@ export class Logo {
           title={this.logoHideTitle ? undefined : this.logoTitle}
           aria-describedby={this.logoAriaDescribedBy}
           aria-hidden={this.logoAriaHidden}
-          tabindex={this.logoAriaHidden ? -1 : 0}
         >
           <scale-logo-svg
             part="icon"
diff --git a/packages/components/src/components/telekom/telekom-footer/telekom-footer-content.tsx b/packages/components/src/components/telekom/telekom-footer/telekom-footer-content.tsx
index 77661d8114..08c6f94e89 100644
--- a/packages/components/src/components/telekom/telekom-footer/telekom-footer-content.tsx
+++ b/packages/components/src/components/telekom/telekom-footer/telekom-footer-content.tsx
@@ -18,7 +18,7 @@ import { Component, h, Host, Prop } from '@stencil/core';
 })
 export class TelekomFooterContent {
   /** (optional) Logo link */
-  @Prop() logoHref?: string = 'javascript:void(0);';
+  @Prop() logoHref?: string = '';
   /** (optional) set logo specific title */
   @Prop() logoTitle?: string = 'Telekom Logo';
   /** (optional) set logo specific title */
@@ -42,6 +42,7 @@ export class TelekomFooterContent {
                 href={this.logoHref}
                 logoHideTitle={this.logoHideTitle}
                 logoTitle={this.logoHideTitle ? undefined : this.logoTitle}
+                focusable={this.logoHref ? true : false}
               ></scale-logo>
             </div>
             <div part="body">
diff --git a/packages/components/src/components/telekom/telekom-header/telekom-header.tsx b/packages/components/src/components/telekom/telekom-header/telekom-header.tsx
index fedda5217c..3d8b192028 100644
--- a/packages/components/src/components/telekom/telekom-header/telekom-header.tsx
+++ b/packages/components/src/components/telekom/telekom-header/telekom-header.tsx
@@ -74,9 +74,9 @@ export class TelekomHeader {
                   part="app-logo"
                   variant="white"
                   href={this.logoHref}
-                  tabindex={this.logoHref ? '0' : '-1'}
                   logoTitle={this.logoTitle}
                   logoHideTitle={this.logoHideTitle}
+                  focusable={this.logoHref ? true : false}
                 ></scale-logo>
               </slot>
 

From 9d9622b31da8ae97e8a81c46d8b8886d0972f0a5 Mon Sep 17 00:00:00 2001
From: felixw <felix.weber@iconstorm.com>
Date: Fri, 24 Nov 2023 15:24:11 +0100
Subject: [PATCH 3/4] docs: update docs

---
 .../src/components/telekom/telekom-footer/readme.md    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/components/src/components/telekom/telekom-footer/readme.md b/packages/components/src/components/telekom/telekom-footer/readme.md
index 239844318f..963758f80b 100644
--- a/packages/components/src/components/telekom/telekom-footer/readme.md
+++ b/packages/components/src/components/telekom/telekom-footer/readme.md
@@ -7,11 +7,11 @@
 
 ## Properties
 
-| Property        | Attribute         | Description                        | Type      | Default                 |
-| --------------- | ----------------- | ---------------------------------- | --------- | ----------------------- |
-| `logoHideTitle` | `logo-hide-title` | (optional) set logo specific title | `boolean` | `false`                 |
-| `logoHref`      | `logo-href`       | (optional) Logo link               | `string`  | `'javascript:void(0);'` |
-| `logoTitle`     | `logo-title`      | (optional) set logo specific title | `string`  | `'Telekom Logo'`        |
+| Property        | Attribute         | Description                        | Type      | Default          |
+| --------------- | ----------------- | ---------------------------------- | --------- | ---------------- |
+| `logoHideTitle` | `logo-hide-title` | (optional) set logo specific title | `boolean` | `false`          |
+| `logoHref`      | `logo-href`       | (optional) Logo link               | `string`  | `''`             |
+| `logoTitle`     | `logo-title`      | (optional) set logo specific title | `string`  | `'Telekom Logo'` |
 
 
 ## Shadow Parts

From 427a4fe763990ad899e3a4b019683616a3375603 Mon Sep 17 00:00:00 2001
From: felixw <felix.weber@iconstorm.com>
Date: Fri, 24 Nov 2023 15:24:26 +0100
Subject: [PATCH 4/4] docs: update docs

---
 .../stories/components/telekom-footer/FooterContent.vue         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/storybook-vue/stories/components/telekom-footer/FooterContent.vue b/packages/storybook-vue/stories/components/telekom-footer/FooterContent.vue
index 1233b0c04e..5df9c0a7e2 100644
--- a/packages/storybook-vue/stories/components/telekom-footer/FooterContent.vue
+++ b/packages/storybook-vue/stories/components/telekom-footer/FooterContent.vue
@@ -2,7 +2,7 @@
   export default {
     name: 'FooterContent',
     props: {
-        logoHref: { type: String, default: 'javascript:void(0);' },
+        logoHref: { type: String, default: '' },
         logoTitle: { type: String, default: 'Telekom Logo' },
         logoHideTitle: { type: Boolean, default: false }
     }