Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose: false, still logs "request finish" #14

Open
sonihimanshu opened this issue Apr 12, 2017 · 4 comments
Open

Verbose: false, still logs "request finish" #14

sonihimanshu opened this issue Apr 12, 2017 · 4 comments

Comments

@sonihimanshu
Copy link

Hi,
Set verbose to false (including explicitly) still logs the request end message. request start message only gets logged with verbose is set to true. Thanks!!

@tellnes
Copy link
Owner

tellnes commented May 12, 2017

There is actually no way to disable that currently.

There is currently two options to control what gets logged, requestStart and verbose. I actually think it is a bit of a mess right now. So I'm open to proposals to create a better configuration api for this.

@tellnes
Copy link
Owner

tellnes commented May 12, 2017

You can set the level parameter to eg. trace and configure bunyan to not log trace level logs.

@sumeetddubey
Copy link

How about we get rid of the verbose flag and instead have logRequestStart and logRequestFinish? Would be a breaking change though.

@tellnes
Copy link
Owner

tellnes commented Dec 20, 2019

@sumeetddubey Yeah, that might be a solution.

Another solution might to split out the part which actually logs. There is a lot of flags to configure it currently. Different people have different opinions on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants