Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow with protected path: Manual reroute: System reuses current protected path when can't find new non overlapping protected path while intentional rerouting #5731

Open
yuliiamir opened this issue Aug 28, 2024 · 0 comments

Comments

@yuliiamir
Copy link
Collaborator

After rechecking the test, it was noticed that env setup/implemented logic is not correct.

TC:
System reuses current protected path when can't find new non overlapping protected path while intentional rerouting

The following swPairs are applicable for the test:
def switchPair = switchPairs.all(false).neighbouring().withExactlyNNonOverlappingPaths(3)
sw3-sw9, sw7-sw9, sw8-sw9 , but the test passes ONLY with sw3-sw9

sw3-sw9: manual reroute: true -> New main path + the same protected path, BUT the strange log: "action": "Found the same protected path. Skipped creating of it", - should it be something about overlapping?

{
    "clazz": "org.openkilda.messaging.payload.history.FlowHistoryEntry",
    "flow_id": "28Aug175153_339_annattoseed8531_flow",
    "timestamp": 1724860356,
    "timestamp_iso": "2024-08-28T15:52:36.568Z",
    "actor": "AUTO",
    "action": "Flow rerouting",
    "task_id": "af4b078d-b069-4a6d-965f-6f4971936ce2 : fn-tests-6d666437-0991-40e6-a019-c3bccf7c4c04",
    "details": "Reason: initiated via Northbound",
    "payload": [
      {
        "timestamp": 1724860356,
        "action": "Flow rerouting operation has been started.",
        "details": null,
        "timestamp_iso": "2024-08-28T15:52:36.568Z"
      },
      {
        "timestamp": 1724860356,
        "action": "The flow has been validated successfully",
        "details": null,
        "timestamp_iso": "2024-08-28T15:52:36.576Z"
      },
      {
        "timestamp": 1724860356,
        "action": "New primary paths were created",
        "details": "The flow paths 28Aug175153_339_annattoseed8531_flow_d221239d-adc8-4692-ae10-a92becd8b106 / 28Aug175153_339_annattoseed8531_flow_58ce77fa-5d58-4c40-a409-3cbaed615e2b were created (with allocated resources)",
        "timestamp_iso": "2024-08-28T15:52:36.727Z"
      },
      {
        "timestamp": 1724860356,
        "action": "Found the same protected path. Skipped creating of it",
        "details": null,
        "timestamp_iso": "2024-08-28T15:52:36.846Z"
      },
      ...
{
        "timestamp": 1724860358,
        "action": "Flow was rerouted successfully",
        "details": null,
        "timestamp_iso": "2024-08-28T15:52:38.337Z"
      }

sw 7-9 manual reroute: false -> old main path + new protected path = incorrect logic

 {
    "clazz": "org.openkilda.messaging.payload.history.FlowHistoryEntry",
    "flow_id": "28Aug171247_298_fishstock1143_flow",
    "timestamp": 1724857986,
    "timestamp_iso": "2024-08-28T15:13:06.689Z",
    "actor": "AUTO",
    "action": "Flow rerouting",
    "task_id": "5bb5aee1-763d-4da0-a205-20a0b6dc7f14 : fn-tests-41466cad-243b-4bf2-a36b-4cdff890b024",
    "details": "Reason: initiated via Northbound",
    "payload": [
      {
        "timestamp": 1724857986,
        "action": "Flow rerouting operation has been started.",
        "details": null,
        "timestamp_iso": "2024-08-28T15:13:06.689Z"
      },
      {
        "timestamp": 1724857986,
        "action": "The flow has been validated successfully",
        "details": null,
        "timestamp_iso": "2024-08-28T15:13:06.698Z"
      },
      {
        "timestamp": 1724857986,
        "action": "Found the same primary path. Skipped creating of it",
        "details": null,
        "timestamp_iso": "2024-08-28T15:13:06.770Z"
      },
      {
        "timestamp": 1724857986,
        "action": "New protected paths were created",
        "details": "The flow paths 28Aug171247_298_fishstock1143_flow_4fa19f89-5b89-434a-9d4c-828d1275af42 / 28Aug171247_298_fishstock1143_flow_201f1f80-f8d3-4bbe-86e4-12d5e3bd408a were created (with allocated resources)",
        "timestamp_iso": "2024-08-28T15:13:06.871Z"
      },
      {
        "timestamp": 1724857986,
        "action": "Commands for installing non ingress rules have been sent",
        "details": null,
        "timestamp_iso": "2024-08-28T15:13:06.928Z"
      },
      {
        "timestamp": 1724857987,
        "action": "Rule was installed",
        "details": "The rule was installed: switch 00:00:00:00:00:00:00:03, cookie 0x40000000000185F2",
        "timestamp_iso": "2024-08-28T15:13:07.082Z"
      }
... {
        "timestamp": 1724857987,
        "action": "Flow was rerouted successfully",
        "details": null,
        "timestamp_iso": "2024-08-28T15:13:07.659Z"
      }

sw 8-9 manual reroute: true -> both main+protected are new paths = incorrect logic

{
    "clazz": "org.openkilda.messaging.payload.history.FlowHistoryEntry",
    "flow_id": "28Aug172256_901_snapper3752_flow",
    "timestamp": 1724859480,
    "timestamp_iso": "2024-08-28T15:38:00.171Z",
    "actor": "AUTO",
    "action": "Flow rerouting",
    "task_id": "14b15241-39de-4530-8523-543269ccd933 : fn-tests-0ca9d82d-79ee-432f-9f26-1b2423164c37",
    "details": "Reason: initiated via Northbound",
    "payload": [
      {
        "timestamp": 1724859480,
        "action": "Flow rerouting operation has been started.",
        "details": null,
        "timestamp_iso": "2024-08-28T15:38:00.171Z"
      },
      {
        "timestamp": 1724859480,
        "action": "The flow has been validated successfully",
        "details": null,
        "timestamp_iso": "2024-08-28T15:38:00.191Z"
      },
      {
        "timestamp": 1724859480,
        "action": "New primary paths were created",
        "details": "The flow paths 28Aug172256_901_snapper3752_flow_c743b1b0-f66c-4b53-88f5-dce91629780f / 28Aug172256_901_snapper3752_flow_2e09c9a8-26c1-46b8-a834-13bac58890d5 were created (with allocated resources)",
        "timestamp_iso": "2024-08-28T15:38:00.343Z"
      },
      {
        "timestamp": 1724859480,
        "action": "New protected paths were created",
        "details": "The flow paths 28Aug172256_901_snapper3752_flow_e0f5accb-f217-4aca-9a18-9289f0216fe8 / 28Aug172256_901_snapper3752_flow_ff16a241-200e-49b1-9c6b-8e818a824751 were created (with allocated resources)",
        "timestamp_iso": "2024-08-28T15:38:00.490Z"
      }

topologyAndPaths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant