Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Remove dependency on Grafana #518

Open
BrianKopp opened this issue Jul 2, 2024 · 3 comments · May be fixed by #526
Open

[Feature Request] Remove dependency on Grafana #518

BrianKopp opened this issue Jul 2, 2024 · 3 comments · May be fixed by #526
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@BrianKopp
Copy link

Is your feature request related to a problem? Please describe.

Monitoring tools shouldn't be specified by this application.

Describe the solution you'd like

Remove dependencies on monitoring tools.

@BrianKopp BrianKopp added the enhancement New feature or request label Jul 2, 2024
@robholland
Copy link
Contributor

I would add that we should continue to add Prometheus annotations though if prometheus.enable is true. Or, maybe a new value with a more intent-revealing name that toggles the annotations.

@BrianKopp
Copy link
Author

Ok sounds good. I'll split these up into two different PRs, the first for grafana, the second for prometheus. The grafana removal is much more straightforward. There are some different choices that could be made on the prometheus side of things for implementing scrape config (labels, servicemonitors, etc.), as well as where to draw the line for what stays in.

@BrianKopp BrianKopp linked a pull request Jul 5, 2024 that will close this issue
@BrianKopp BrianKopp changed the title [Feature Request] Remove dependencies on monitoring tools [Feature Request] Remove dependency on Grafana Jul 5, 2024
@BrianKopp
Copy link
Author

Moving Prometheus discussion to #527

@robholland robholland added this to the 1.0 milestone Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants