Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] helm upgrade does not work if schema.enabled is true #554

Open
kosmoz opened this issue Sep 10, 2024 · 3 comments · May be fixed by #555 or #559
Open

[Bug] helm upgrade does not work if schema.enabled is true #554

kosmoz opened this issue Sep 10, 2024 · 3 comments · May be fixed by #555 or #559
Assignees
@robholland
Labels
bug Something isn't working

Comments

@kosmoz
Copy link

kosmoz commented Sep 10, 2024

What are you really trying to do?

Running helm upgrade on an existing release of the temporal chart.

Describe the bug

Schema migrations are performed in a Job, but the resource is never garbage collected. When trying to upgrade the release, helm fails because the Job resource has immutable fields.

Minimal Reproduction

  1. Install helm chart
  2. Try to upgrade helm release

Environment/Versions

  • Temporal Version: helm chart 0.45.0

Additional context
@kosmoz kosmoz added the bug Something isn't working label Sep 10, 2024
@kosmoz
Copy link
Author

kosmoz commented Sep 10, 2024

Can be fixed by setting the ttlSecondsAfterFinished on the Job. I will create a PR shortly.

@kosmoz kosmoz linked a pull request Sep 10, 2024 that will close this issue
Open
@FurqanHabibi
Copy link

FurqanHabibi commented Sep 19, 2024 •
edited
Loading

Another alternative is to specify the job as a pre-install hook. Will create a PR with this approach.

@FurqanHabibi FurqanHabibi linked a pull request Sep 19, 2024 that will close this issue
Open
@robholland
Copy link
Contributor

Please give #564 a try.

@robholland robholland self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robholland robholland

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@robholland @FurqanHabibi @kosmoz