Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server-pdb #573

Closed
wants to merge 1 commit into from
Closed

Fix server-pdb #573

wants to merge 1 commit into from

Conversation

FurqanHabibi
Copy link

What was changed

Changed . to $ in server-pdb range block since . in range doesn't refer to top level scope.

Why?

Currently server-pdb is broken and not deployable.
image

Checklist

  1. Closes [Bug] server-pdb is broken #572

  2. How was this tested:
    Tested deploying with pdb enabled

    helm install \
    --repo https://go.temporal.io/helm-charts \
    --set server.frontend.replicaCount=2 \
    --set server.frontend.podDisruptionBudget.minAvailable=1 \
    temporaltest temporal \
    --timeout 15m

  3. Any docs updates needed?
    No

@FurqanHabibi FurqanHabibi requested a review from a team as a code owner October 1, 2024 02:56
@robholland
Copy link
Contributor

This was fixed in #568

@robholland robholland closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] server-pdb is broken
2 participants
@FurqanHabibi @robholland