Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Don't retry INTERNAL gRPC errors by default #773

Closed
Sushisource opened this issue Jul 3, 2024 · 1 comment
Closed

[Bug] Don't retry INTERNAL gRPC errors by default #773

Sushisource opened this issue Jul 3, 2024 · 1 comment
Assignees
@Sushisource
Labels
bug Something isn't working

Comments

@Sushisource
Copy link
Member

After a bunch of talk we decided not to retry these by default, and possibly whitelist certain INTERNAL errors that should be retryable. EX: stream resets (but, we don't know if those would even happen in hyper and if so what form they take).
@Sushisource Sushisource added the bug Something isn't working label Jul 3, 2024
@Sushisource Sushisource self-assigned this Jul 3, 2024
@Sushisource
Copy link
Member Author

This doesn't seem to be a real problem in any way. Would rather see this get dealt with by having server return explicit retry settings in errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sushisource Sushisource

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sushisource