CHASM Scheduler Experimental Flag #8467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaptersix
commented
Oct 10, 2025
chaptersix
commented
Oct 10, 2025
chaptersix
commented
Oct 10, 2025
…ix nil slice
- Rename FrontendEnabledExperiments to FrontendAllowedExperiments to better reflect that this is an allowlist
- Change dynamic config key from frontend.enabledExperiments to frontend.allowedExperiments
- Fix default value from []string{} to []string(nil) to avoid shared structure warning
- Update all references in Config struct and IsExperimentEnabled method
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
bergundy
reviewed
Oct 10, 2025
chaptersix
commented
Oct 13, 2025
chaptersix
commented
Oct 13, 2025
chaptersix
commented
Oct 13, 2025
chaptersix
commented
Oct 13, 2025
bergundy
reviewed
Oct 14, 2025
chaptersix
commented
Oct 15, 2025
- Add nolint:revive for cognitive-complexity in executors.go and handler.go - Add nolint:staticcheck for deprecated API usage in nexus_workflow_test.go 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
# Conflicts: # components/nexusoperations/executors.go # components/nexusoperations/frontend/handler.go # tests/nexus_workflow_test.go
bergundy
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added support for enabling experimental features via gRPC headers and namespace configuration:
- Added temporal-experimental gRPC header support
- supports comma-separated values, wildcards (*), and case-insensitive matching
- Added FrontendEnabledExperiments dynamic config setting to allow per-namespace control of which experiments can be enabled
- Defined ChasmSchedulerExperiment = "chasm-sch" constant
- Refactored common/headers/headers_test.go to remove testify suite pattern and use standard table-driven tests with t.Parallel()
Why?
We need a safe, controlled way to roll out experimental features like the CHASM scheduler (v2). This infrastructure provides:
How did you test it?