Add workflowId parameter to namespace.ActiveClusterName api. #8740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwduan
changed the title
yux0
reviewed
Dec 3, 2025
Comment on lines
371
to
+373
| if ns.IsGlobalNamespace() && | ||
| ns.ReplicationPolicy() == namespace.ReplicationPolicyMultiCluster && | ||
| ns.ActiveClusterName() == e.currentClusterName { | ||
| ns.ActiveInCluster(e.currentClusterName) { |
Contributor
There was a problem hiding this comment.
We need to think more about this. I am not sure if this is correct
Contributor
Author
There was a problem hiding this comment.
From code semantic, it is correct, because ActiveInCluster underlying calling ns.ActiveClusterName api. From logic perspective, you are right to question this. This is to detect the when the current cluster become active. We will introduce ns.StateChanged API to handle this case instead of using ns.ActiveClusterName.
michaely520
reviewed
Dec 3, 2025
| } | ||
|
|
||
| return namespaceEntry.ActiveClusterName(), true | ||
| return namespaceEntry.ActiveClusterName(""), true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add workflowId parameter to namespace.ActiveClusterName api
Why?
So we can have different replication config for different workflowId.
How did you test it?
Potential risks
No risk.