Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset workflow modal bugs #2146

Open
varunbpatil opened this issue Jun 10, 2024 · 0 comments · May be fixed by #2147
Open

Reset workflow modal bugs #2146

varunbpatil opened this issue Jun 10, 2024 · 0 comments · May be fixed by #2147
Labels
bug Something isn't working

Comments

@varunbpatil
Copy link

Describe the bug
The "Reset Workflow" modal has a few small bugs.

  1. Allows clicking "Confirm" without selecting an event-id which results in an error from the backend.
  2. The error is not displayed to the user because the modal is closed immediately.
  3. The description for the event-id radiogroup should be fixed in position instead of scrolling along with the event id's.

Expected behavior

  1. "Confirm" button should be disabled if an event-id is not selected.
  2. The modal should not be closed on an error.
  3. The description for the event-id radiogroup should be fixed in position.
@varunbpatil varunbpatil added the bug Something isn't working label Jun 10, 2024
varunbpatil added a commit to varunbpatil/ui that referenced this issue Jun 10, 2024
@varunbpatil
Fix reset workflow modal bugs
4caffea 
Fixes temporalio#2146
@varunbpatil varunbpatil linked a pull request Jun 10, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reset workflow modal bugs varunbpatil/ui
1 participant
@varunbpatil