Is it an issue with installation on windows. Because it worked smoothly on MaC but giving problems on windows

[ajaykumarmoodys]

1. The initial error occurs with mat_decomp.h, which I changed using explicit type casting under the std::max

(xfac-test) (xfac-test) PS C:\Users\kumara98\OneDrive - moodys.com\Desktop\xfac-test2\xfac> cmake --build build -j 4
MSBuild version 17.12.6+db5f6012c for .NET Framework

1>Checking Build System
Building Custom Rule C:/Users/kumara98/OneDrive - moodys.com/Desktop/xfac-test2/xfac/CMakeLists.txt
xfac.vcxproj -> C:\Users\kumara98\OneDrive - moodys.com\Desktop\xfac-test2\xfac\build\Debug\xfac.lib
python_bindings.cpp
C:\Users\kumara98\OneDrive - moodys.com\Desktop\xfac-test2\xfac\include\xfac\matrix\mat_decomp.h(272,60): err
or C2672: 'max': no matching overloaded function found [C:\Users\kumara98\OneDrive - moodys.com\Desktop\xfac-
test2\xfac\build\python\xfacpy.vcxproj]
(compiling source file '../../python/python_bindings.cpp')

2. I still face warning (and not errors) after this change.

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\utility(263,54): wa
rning C4267: 'initializing': conversion from 'size_t' to '_Ty2', possible loss of data [C:\Users\kumara98\One
Drive - moodys.com\Desktop\xfacpy\xfac\build\python\xfacpy.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\utility(263,54): wa
rning C4267: with [C:\Users\kumara98\OneDrive - moodys.com\Desktop\xfacpy\xfac\build\python\xfacpy.vc
xproj]
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\utility(263,54): wa
rning C4267: [ [C:\Users\kumara98\OneDrive - moodys.com\Desktop\xfacpy\xfac\build\python\xfacpy.vcxpr
oj]
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\utility(263,54): wa
rning C4267: _Ty2=int [C:\Users\kumara98\OneDrive - moodys.com\Desktop\xfacpy\xfac\build\python\x
facpy.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\utility(263,54): wa
rning C4267: ] [C:\Users\kumara98\OneDrive - moodys.com\Desktop\xfacpy\xfac\build\python\xfacpy.vcxpr
oj]

3. But ultimately, I am not able to import xfacpy and it gives me error:
   import os
   os.chdir("c:\Users\kumara98\OneDrive - moodys.com\Desktop\xfacpy\xfac\build\python")
   os.listdir()
   ['CMakeFiles',
   'cmake_install.cmake',
   'Debug',
   'INSTALL.vcxproj',
   'INSTALL.vcxproj.filters',
   'xfacpy.dir',
   'xfacpy.vcxproj',
   'xfacpy.vcxproj.filters']

import sys
sys.path.append("c:\Users\kumara98\OneDrive - moodys.com\Desktop\xfacpy\xfac\build\python")

import os
import sys
module_path = os.path.abspath(os.path.join('../..'))
utls_path = os.path.abspath(os.path.join('..'))
if module_path not in sys.path:
sys.path.append(module_path)
if utls_path not in sys.path:
sys.path.append(utls_path)

import xfacpy
--------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
Cell In[22], line 1
----> 1 import xfacpy
ModuleNotFoundError: No module named 'xfacpy'

cmake build.txt
install file.txt

[yurielnf]

Dear @ajaykumarmoodys,
Thanks for your feedback! We have not tested the compilation on Windows, but now that you are interested in, we will.
We first need to check that armadillo works, as they provide particular lapack/blas libraries for Windows (see here). Probably we need to adapt our cmake accordingly.
Kind regards,
Yuriel

[ajaykumarmoodys]

Hi @yurielnf ,

I hope you are doing well. I just wanted to check if you had an opportunity to review the xfac package for window?

Thank you,
Ajay

[yurielnf]

Hi Ajay,

Sorry! Not yet. I have putted it in schedule for next week.

Best,
Yuriel