CRITICAL: decode.decode never resets expiry and propagates it to keys that shouldn't have it! #3

justonia · 2015-12-07T21:48:50Z

In the decoder's decode method, once a key is read that has an expiry that expiry will be provided to every single object read afterwards. For someone trying to restore a Redis DB from the RDB file, this would be a Bad Thing. I will make a PR ASAP as the fix is easy.

…hat don't have expiry

Fix issue #3 where key expiry is incorrectly propagated to keys without expiry

justonia pushed a commit to justonia/rdb that referenced this issue Dec 7, 2015

Fix issue tent#3 where key expiry is incorrectly propogated to keys t…

0c276fd

…hat don't have expiry

titanous added a commit that referenced this issue Dec 7, 2015

Merge pull request #4 from justonia/fix-expiry

f5614b4

Fix issue #3 where key expiry is incorrectly propagated to keys without expiry

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRITICAL: decode.decode never resets expiry and propagates it to keys that shouldn't have it! #3

CRITICAL: decode.decode never resets expiry and propagates it to keys that shouldn't have it! #3

justonia commented Dec 7, 2015

CRITICAL: decode.decode never resets expiry and propagates it to keys that shouldn't have it! #3

CRITICAL: decode.decode never resets expiry and propagates it to keys that shouldn't have it! #3

Comments

justonia commented Dec 7, 2015