Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions Not Pulling Latest Docker Image When Building Tur-On-Device Packages #869

Closed
Kapral67 opened this issue Mar 1, 2024 · 4 comments

Comments

@Kapral67
Copy link
Contributor

Kapral67 commented Mar 1, 2024

actions still not pulling latest built image from termux-user-repoistory/termux-docker so dns resolution is failing

Originally posted by @Kapral67 in #863 (comment)

We might be able to fix with something like:

index cad11a0..d3e4cb4 100755
--- a/common-files/build-termux-docker.sh
+++ b/common-files/build-termux-docker.sh
@@ -23,7 +23,8 @@ fi
 echo "Running container '$CONTAINER_NAME' from image '$TERMUX_BUILDER_IMAGE_NAME'..."

 $SUDO docker start $CONTAINER_NAME >/dev/null 2>&1 || {
-   echo "Creating new container..."
+    $SUDO docker pull $TERMUX_BUILDER_IMAGE_NAME
+    echo "Creating new container..."
    $SUDO docker run \
        --detach \
        --name $CONTAINER_NAME \

but I have no way to test as I only have the latest image

@licy183
Copy link
Collaborator

licy183 commented Mar 2, 2024

The latest image has been pulled. Removing --network=host should resolve this.

@Kapral67
Copy link
Contributor Author

Kapral67 commented Mar 2, 2024

On my local computer, the container has dns resolution with --network=host set. Is this issue something specific to the github actions environment?

@licy183
Copy link
Collaborator

licy183 commented Mar 3, 2024

Should be fixed by 3544d92

@licy183 licy183 closed this as completed Mar 3, 2024
@Kapral67
Copy link
Contributor Author

Kapral67 commented Mar 3, 2024

that did it, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants