Skip to content

Commit 692d07d

Browse files
authored
feat: Support kafka_settings.sasl_mechanism and resource_identifier (#86)
1 parent 6c116cc commit 692d07d

File tree

8 files changed

+13
-10
lines changed

8 files changed

+13
-10
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -304,14 +304,14 @@ Examples codified under the [`examples`](https://github.com/terraform-aws-module
304304
| Name | Version |
305305
|------|---------|
306306
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0 |
307-
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.32 |
307+
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.83 |
308308
| <a name="requirement_time"></a> [time](#requirement\_time) | >= 0.9 |
309309

310310
## Providers
311311

312312
| Name | Version |
313313
|------|---------|
314-
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 5.32 |
314+
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 5.83 |
315315
| <a name="provider_time"></a> [time](#provider\_time) | >= 0.9 |
316316

317317
## Modules

examples/complete/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ Note that this example may create resources which will incur monetary charges on
2828
| Name | Version |
2929
|------|---------|
3030
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0 |
31-
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.31 |
31+
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.83 |
3232

3333
## Providers
3434

3535
| Name | Version |
3636
|------|---------|
37-
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 5.31 |
37+
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 5.83 |
3838

3939
## Modules
4040

examples/complete/main.tf

+1
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ module "dms_aurora_postgresql_aurora_mysql" {
148148
include_control_details = true
149149
include_null_and_empty = true
150150
message_format = "json"
151+
sasl_mechanism = "scram-sha-512"
151152
sasl_password = local.sasl_scram_credentials["password"]
152153
sasl_username = local.sasl_scram_credentials["username"]
153154
security_protocol = "sasl-ssl"

examples/complete/versions.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
required_providers {
55
aws = {
66
source = "hashicorp/aws"
7-
version = ">= 5.31"
7+
version = ">= 5.83"
88
}
99
}
1010
}

examples/serverless/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ Note that this example may create resources which will incur monetary charges on
2626
| Name | Version |
2727
|------|---------|
2828
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0 |
29-
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.32 |
29+
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.83 |
3030

3131
## Providers
3232

3333
| Name | Version |
3434
|------|---------|
35-
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 5.32 |
35+
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 5.83 |
3636

3737
## Modules
3838

examples/serverless/versions.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
required_providers {
55
aws = {
66
source = "hashicorp/aws"
7-
version = ">= 5.32"
7+
version = ">= 5.83"
88
}
99
}
1010
}

main.tf

+3-1
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ resource "aws_dms_endpoint" "this" {
211211
message_max_bytes = try(kafka_settings.value.message_max_bytes, null)
212212
no_hex_prefix = try(kafka_settings.value.no_hex_prefix, null)
213213
partition_include_schema_table = try(kafka_settings.value.partition_include_schema_table, null)
214+
sasl_mechanism = try(kafka_settings.value.sasl_mechanism, null)
214215
sasl_password = lookup(kafka_settings.value, "sasl_password", null)
215216
sasl_username = lookup(kafka_settings.value, "sasl_username", null)
216217
security_protocol = try(kafka_settings.value.security_protocol, null)
@@ -392,7 +393,8 @@ resource "aws_dms_replication_task" "this" {
392393
replication_instance_arn = aws_dms_replication_instance.this[0].replication_instance_arn
393394
replication_task_id = each.value.replication_task_id
394395
replication_task_settings = try(each.value.replication_task_settings, null)
395-
source_endpoint_arn = try(each.value.source_endpoint_arn, aws_dms_endpoint.this[each.value.source_endpoint_key].endpoint_arn, aws_dms_s3_endpoint.this[each.value.source_endpoint_key].endpoint_arn)
396+
resource_identifier = try(each.value.resource_identifier, null)
397+
source_endpoint_arn = try(aws_dms_endpoint.this[each.value.source_endpoint_key].endpoint_arn, aws_dms_s3_endpoint.this[each.value.source_endpoint_key].endpoint_arn)
396398
start_replication_task = try(each.value.start_replication_task, null)
397399
table_mappings = try(each.value.table_mappings, null)
398400
target_endpoint_arn = try(each.value.target_endpoint_arn, aws_dms_endpoint.this[each.value.target_endpoint_key].endpoint_arn, aws_dms_s3_endpoint.this[each.value.target_endpoint_key].endpoint_arn)

versions.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
required_providers {
55
aws = {
66
source = "hashicorp/aws"
7-
version = ">= 5.32"
7+
version = ">= 5.83"
88
}
99
time = {
1010
source = "hashicorp/time"

0 commit comments

Comments
 (0)