feat: Allow for policy creation for externally created s3 buckets #312
+171
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
changed the title
ghost
changed the title
ghost
changed the title
ghost
marked this pull request as ready for review
|
We will not support cases where the core resource (S3 bucket itself) is not created. It is a prerequisite for this module to do anything. #305 should probably be solved another way; I don't have time to look into that one now. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to the count which controls whether policy will be created/updated so that policies can be independently created for externally created s3 buckets, this is particularly useful if you use the module to create a bucket then create a cloudfront to serve the bucket and have to make adjustments to the policy after the bucket has been created as described in #305
Motivation and Context
Experienced the problem first hand and also resolves #305
Breaking Changes
This shouldn't break backwards compatibility
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request