Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for require_partition_filter in the external tables #342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NitriKx
Copy link

@NitriKx NitriKx commented Aug 8, 2024

This PR adds the require_partition_filter option for the external tables.

From what I've experimented it seems that the "top-level" require_partition_filter option does not work here and needs to be set in the hive_partitioning_options.

Copy link

google-cla bot commented Aug 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NitriKx NitriKx force-pushed the add-require-partition-filter-external-tables branch 5 times, most recently from 171c433 to b7c42ff Compare August 8, 2024 07:57
@NitriKx NitriKx marked this pull request as ready for review August 8, 2024 07:57
@NitriKx NitriKx requested review from davenportjw, shanecglass and a team as code owners August 8, 2024 07:57
@bharathkkb
Copy link
Member

/gcbrun

1 similar comment
@bharathkkb
Copy link
Member

/gcbrun

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @NitriKx! Could you regenerate the docs running make docker_generate_docs?

@NitriKx NitriKx force-pushed the add-require-partition-filter-external-tables branch from 466789a to 66d6d05 Compare August 18, 2024 08:17
@NitriKx
Copy link
Author

NitriKx commented Aug 18, 2024

Oops forgot this step, I've just pushed the doc update @bharathkkb

@NitriKx NitriKx requested a review from bharathkkb August 18, 2024 14:33
@NitriKx
Copy link
Author

NitriKx commented Oct 10, 2024

Hello @bharathkkb, any news on this one?

Copy link

github-actions bot commented Dec 9, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants