Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add example for encrypted tfstate bucket #240

Closed
wants to merge 5 commits into from
Closed

chore: add example for encrypted tfstate bucket #240

wants to merge 5 commits into from

Conversation

imrannayer
Copy link
Contributor

Fix #119

@imrannayer imrannayer requested a review from a team as a code owner July 25, 2023 12:15
@imrannayer imrannayer changed the title feat: add example for encrypted tfstate bucket chore: add example for encrypted tfstate bucket Jul 25, 2023
@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

@imrannayer
Copy link
Contributor Author

@bharathkkb can u plz check why tests are failing?

@daniel-cit
Copy link
Contributor

It looks like to be this issue GoogleCloudPlatform/cloud-foundation-toolkit#1721

Error while installing hashicorp/google v4.75.0: open
/workspace/test/integration/tmp/.terraform/registry.terraform.io/hashicorp/google/4.75.0/linux_amd64/terraform-provider-google_v4.75.0_x5:
text file busy
}
    init.go:13: FatalError{Underlying: error while running command: exit status 1; 
        Error: Failed to install provider
        
        Error while installing hashicorp/google v4.75.0: open
        /workspace/test/integration/tmp/.terraform/registry.terraform.io/hashicorp/google/4.75.0/linux_amd64/terraform-provider-google_v4.75.0_x5:
        text file busy
        }

@bharathkkb
Copy link
Member

/gcbrun

@imrannayer
Copy link
Contributor Author

Pipeline timed out. Parallelize a few tasks.

@imrannayer imrannayer requested a review from bharathkkb July 31, 2023 16:44
@imrannayer
Copy link
Contributor Author

@bharathkkb can you plz execute integration test again?

@bharathkkb
Copy link
Member

/gcbrun

1 similar comment
@g-awmalik
Copy link
Contributor

/gcbrun

bharathkkb
bharathkkb reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an init all step that other applies depend on so the init happens serially?
terraform-google-modules/terraform-google-project-factory#823

@imrannayer
Copy link
Contributor Author

@bharathkkb added steps in integration test

@bharathkkb
Copy link
Member

/gcbrun

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 10, 2023
@github-actions github-actions bot closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb left review comments

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example and tests for encrypted state bucket with cmek
4 participants
@imrannayer @bharathkkb @daniel-cit @g-awmalik