Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed project will have the creator as owner #34

Open
umairidris opened this issue Jun 12, 2020 · 4 comments
Open

Seed project will have the creator as owner #34

umairidris opened this issue Jun 12, 2020 · 4 comments
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work

Comments

@umairidris
Copy link

When creating a GCP project the creating user is granted owner access to the project. Given this module will likely be called by a human, a human will have owner access to the seed project.

Thus, we should consider adding an iam_binding to transfer roles/owner to a central group.

@rjerrems
Copy link
Contributor

Yeah historically this module actually did this, but it introduced some flakiness at the time which would cause project creation to fail. I would be happy to accept a PR that sets this to something like the org_admins group if you are able to get it working consistently

@umairidris
Copy link
Author

umairidris commented Jun 15, 2020

Do you have some insights into the type of flakiness? I have used project_iam_binding for this, as long as the user is in the new owners group they should continue to have access but I don't know if there are some issues with this approach.

@rjerrems
Copy link
Contributor

Yeah its been quite a while since I last did this, so its possible that its a non-issue now. Given its a small change perhaps we try adding it and running through the test suite a few times?

@morgante
Copy link
Contributor

iam_binding should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

3 participants