Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service range optional #1949

Open
TheKangaroo opened this issue May 21, 2024 · 6 comments
Open

Make service range optional #1949

TheKangaroo opened this issue May 21, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@TheKangaroo
Copy link
Contributor

TL;DR

There is a new default service IP range which should be used for new 1.29.3+ clusters:

GKE versions up to 1.29.2 will create a random /20 range from 10.0.0.0/8 if ip_range_services is omitted. From 1.29.3 this will set the new default service range 34.118.224.0/20 on each cluster. ( See https://cloud.google.com/kubernetes-engine/docs/release-notes#May_10_2024 )

Currently it is possible to use the new default service range by explicitly setting var.ip_range_services to null.
This works for our use case, but I was wondering if you wanted this to be the default for the module in the future. I'm happy to provide a PR for this, but wanted to make sure it was something that was wanted.

Terraform Resources

# something like this:
 
 variable "ip_range_services" {
   type        = string
-  description = "The _name_ of the secondary subnet range to use for services"
+  description = "The _name_ of the secondary subnet range to use for services. Omit to use default range."
+  default     = null
 }

Detailed design

No response

Additional information

No response

@TheKangaroo TheKangaroo added the enhancement New feature or request label May 21, 2024
0Delta added a commit to 0Delta/terraform-google-kubernetes-engine that referenced this issue Jul 4, 2024
…#1949)

As of GKE version 1.29 and Autopilot 1.27, the service ip range is given a default of 34.118.224.0/20 per cluster.
Versions earlier than the specified version may be omitted, but will be rejected by the validator.
0Delta added a commit to 0Delta/terraform-google-kubernetes-engine that referenced this issue Jul 4, 2024
…#1949)

As of GKE version 1.29 and Autopilot 1.27, the service ip range is given a default of 34.118.224.0/20 per cluster.
Versions earlier than the specified version may be omitted, but will be rejected by the validator.
@0Delta
Copy link
Contributor

0Delta commented Jul 4, 2024

I agree with this change, but I feel it needs validation.
I've created a PR for now, what do you think?

@TheKangaroo
Copy link
Contributor Author

@0Delta I love your PR. Lets see what the maintainers think about it.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 14, 2024
@TheKangaroo
Copy link
Contributor Author

@apeabody is this something you would consider improving in this module?

@apeabody
Copy link
Contributor

change: ip_range_services to optional value (#1949) #1989

Hi @TheKangaroo - Yes, looks like #1989 is currently waiting on the addition of test coverage. However additional PRs are welcomed.

@github-actions github-actions bot removed the Stale label Sep 16, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Nov 15, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@apeabody apeabody reopened this Nov 22, 2024
@github-actions github-actions bot removed the Stale label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants