Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple pod_range from enable_private_nodes in node_pools #2021

Open
M4C4R opened this issue Aug 1, 2024 · 5 comments
Open

Decouple pod_range from enable_private_nodes in node_pools #2021

M4C4R opened this issue Aug 1, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@M4C4R
Copy link

M4C4R commented Aug 1, 2024

TL;DR

We wanted to convert an existing node pool from public to private, so made the following change in our config:

module "kubernetes_engine" {
  source  = "terraform-google-modules/kubernetes-engine/google"
  version = "31.1.0"
  ...
  node_pools = [
    {
      name         = "example"
      machine_type = "e2-medium"
      # per zone
      node_count  = 1
      preemptible = true
      autoscaling = false
+     enable_private_nodes = true
    },
  ]
...
}

However, no changes were noticed as a part of this.

Expected behavior

I expected my node pool to be converted to private.

Observed behavior

Terraform noticed no changes.

Terraform Configuration

node_pools = [
    {
      name         = "central-ciqa"
      machine_type = "e2-medium"
      # per zone
      node_count  = 1
      preemptible = true
      autoscaling = false
      enable_private_nodes = true
    },
  ]

Terraform Version

Terraform v1.7.4
on darwin_arm64
+ provider registry.terraform.io/hashicorp/google v5.36.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.27.0
+ provider registry.terraform.io/hashicorp/random v3.6.2

Your version of Terraform is out of date! The latest version
is 1.9.3. You can update by downloading from https://www.terraform.io/downloads.html

Additional information

Seems that pod_range is coupled with enable_private_nodes and this has been raised before:

@M4C4R M4C4R added the bug Something isn't working label Aug 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 1, 2024
@M4C4R
Copy link
Author

M4C4R commented Oct 2, 2024

This is still valid.

@github-actions github-actions bot removed the Stale label Oct 2, 2024
@Jibux
Copy link

Jibux commented Oct 3, 2024

We are also affected by this issue. As mentioned in the documentation, this should work! https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google/latest#node_pools-variable

Copy link

github-actions bot commented Dec 2, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 2, 2024
@emalihin
Copy link

emalihin commented Dec 9, 2024

this is still missing?

@github-actions github-actions bot removed the Stale label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants