feat(cgroup): add support for configuring Linux cgroup mode in autopilot clusters #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ameausoone
force-pushed
the
feat/2264/cgroupv2
branch
from
ed85cfe to
ca6fcc6
Compare
apeabody
reviewed
Feb 13, 2025
…lot clusters This update introduces a new `linux_cgroup_mode` variable to specify the cgroup hierarchy mode for autopilot Kubernetes nodes. Supported values include `CGROUP_MODE_UNSPECIFIED`, `CGROUP_MODE_V1`, and `CGROUP_MODE_V2`. Adjusted cluster configurations to include dynamic management of the Linux node configuration based on this variable.
Updated the condition block in `node_pools_cgroup_mode` validation across multiple variables files to use a more readable multi-line format.
Updated variable validation logic to use the `coalesce` function instead of conditional operators for `node_pools_cgroup_mode`, improving readability and consistency across modules.
…ables.tf`" This reverts commit 7434326.
Ameausoone
force-pushed
the
feat/2264/cgroupv2
branch
from
9bd0855 to
efe18f2
Compare
I think this issue will be quickly deprecated |
Yes, here is the plan for Standard: https://cloud.google.com/kubernetes-engine/docs/how-to/migrate-cgroupv2#transition-plan I've requested additional clarification for Autopilot. Ref: |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
apeabody
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Thanks for the contribution @Ameausoone!
We would also want to add example/test coverage for this changes similar to #2273
apeabody
requested changes
Mar 4, 2025
There was a problem hiding this comment.
Hi @Ameausoone!
Could you please add to an example, so we have test coverage for this changes. Could be similar to #2273
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a new
linux_cgroup_modevariable to specify the cgroup hierarchy mode for autopilot Kubernetes nodes. Supported values includeCGROUP_MODE_UNSPECIFIED,CGROUP_MODE_V1, andCGROUP_MODE_V2. Adjusted cluster configurations to include dynamic management of the Linux node configuration based on this variable.Closes #2264