fix: use provided k8s version even when a release channel is specified

[jamiezieziula]

Related to #1279 & #1356 - this aims to allow users to define both a release channel to use as well as a defined version of kubernetes.

[bharathkkb]

Thanks for the PR @jamiezieziula Can we append to an existing test to make sure this is WAI.

terraform-google-kubernetes-engine/examples/simple_regional_beta/main.tf

Line 53 in 2316e77

release_channel = "REGULAR"

seenms like a good candidate.

terraform-google-kubernetes-engine/test/integration/safer_cluster/controls/gcloud.rb

Lines 39 to 43 in ab9c3c5

	it "has expected explicit version" do
	expect(data['currentMasterVersion']).to eq explicit_version
	expect(data['currentNodeVersion']).to eq explicit_version
	end

is an example where we test the expected explicit version.

[jamiezieziula]

@bharathkkb done!

[bharathkkb]

Hi @jamiezieziula I am seeing an error where builds are failing with

  module.this.module.gke.google_container_cluster.primary: Still creating... [5m30s elapsed]
       ╷
       │ Error: Error waiting for creating GKE cluster: Failed to create cluster

Did setting both min_master_version and release_channel work in your environment? I did some investigation and it seemed like there was a previous issue #383 which we then added this conditional as a fix.

[comment-bot-dev]

@jamiezieziula
Thanks for the PR! 🚀
✅ Lint checks have passed.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[kespineira]

Hello! Was there any reason that this PR was not continued with?

[emonisme]

any update on this PR?

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days