From 44abad14a23b0cb02b75517df0245cabc5075ab8 Mon Sep 17 00:00:00 2001 From: Carson Dunbar Date: Tue, 10 Dec 2024 20:05:38 +0000 Subject: [PATCH] Addressing PR review comments --- README.md | 1 + modules/vpc/README.md | 1 + modules/vpc/variables.tf | 4 ++-- modules/vpc/versions.tf | 2 +- variables.tf | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 95cc0d60..b88c9cb7 100644 --- a/README.md +++ b/README.md @@ -117,6 +117,7 @@ Then perform the following commands on the root folder: | mtu | The network MTU (If set to 0, meaning MTU is unset - defaults to '1460'). Recommended values: 1460 (default for historic reasons), 1500 (Internet default), or 8896 (for Jumbo packets). Allowed are all values in the range 1300 to 8896, inclusively. | `number` | `0` | no | | network\_firewall\_policy\_enforcement\_order | Set the order that Firewall Rules and Firewall Policies are evaluated. Valid values are `BEFORE_CLASSIC_FIREWALL` and `AFTER_CLASSIC_FIREWALL`. (default null or equivalent to `AFTER_CLASSIC_FIREWALL`) | `string` | `null` | no | | network\_name | The name of the network being created | `string` | n/a | yes | +| network\_profile | "A full or partial URL of the network profile to apply to this network.
This field can be set only at resource creation time. For example, the
following are valid URLs:
* https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name}
* projects/{projectId}/global/networkProfiles/{network\_profile\_name} | `string` | `null` | no | | project\_id | The ID of the project where this VPC will be created | `string` | n/a | yes | | routes | List of routes being created in this VPC | `list(map(string))` | `[]` | no | | routing\_mode | The network routing mode (default 'GLOBAL') | `string` | `"GLOBAL"` | no | diff --git a/modules/vpc/README.md b/modules/vpc/README.md index 3643a14a..17711c1b 100644 --- a/modules/vpc/README.md +++ b/modules/vpc/README.md @@ -36,6 +36,7 @@ module "vpc" { | mtu | The network MTU (If set to 0, meaning MTU is unset - defaults to '1460'). Recommended values: 1460 (default for historic reasons), 1500 (Internet default), or 8896 (for Jumbo packets). Allowed are all values in the range 1300 to 8896, inclusively. | `number` | `0` | no | | network\_firewall\_policy\_enforcement\_order | Set the order that Firewall Rules and Firewall Policies are evaluated. Valid values are `BEFORE_CLASSIC_FIREWALL` and `AFTER_CLASSIC_FIREWALL`. (default null or equivalent to `AFTER_CLASSIC_FIREWALL`) | `string` | `null` | no | | network\_name | The name of the network being created | `string` | n/a | yes | +| network\_profile | "A full or partial URL of the network profile to apply to this network.
This field can be set only at resource creation time. For example, the
following are valid URLs:
* https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name}
* projects/{projectId}/global/networkProfiles/{network\_profile\_name} | `string` | `null` | no | | project\_id | The ID of the project where this VPC will be created | `string` | n/a | yes | | routing\_mode | The network routing mode (default 'GLOBAL') | `string` | `"GLOBAL"` | no | | shared\_vpc\_host | Makes this project a Shared VPC host if 'true' (default 'false') | `bool` | `false` | no | diff --git a/modules/vpc/variables.tf b/modules/vpc/variables.tf index a8dab8a7..e0755307 100644 --- a/modules/vpc/variables.tf +++ b/modules/vpc/variables.tf @@ -82,10 +82,10 @@ variable "network_profile" { type = string default = null description = <<-EOT - "A full or partial URL of the network profile to apply to this network. + "A full or partial URL of the network profile to apply to this network. This field can be set only at resource creation time. For example, the following are valid URLs: * https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name} * projects/{projectId}/global/networkProfiles/{network_profile_name} EOT -} \ No newline at end of file +} diff --git a/modules/vpc/versions.tf b/modules/vpc/versions.tf index 0fcf093b..943e5dba 100644 --- a/modules/vpc/versions.tf +++ b/modules/vpc/versions.tf @@ -24,7 +24,7 @@ terraform { } google-beta = { source = "hashicorp/google-beta" - version = ">= 6.13.0, < 7" + version = ">= 6.13, < 7" } } diff --git a/variables.tf b/variables.tf index 2d2f59c8..8cbb4fb4 100644 --- a/variables.tf +++ b/variables.tf @@ -204,7 +204,7 @@ variable "network_profile" { type = string default = null description = <<-EOT - "A full or partial URL of the network profile to apply to this network. + "A full or partial URL of the network profile to apply to this network. This field can be set only at resource creation time. For example, the following are valid URLs: * https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name}