Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restrict provider version to "<5.0" for modules missing max version #501

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix: restrict provider version to "<5.0" for modules missing max version #501

merged 2 commits into from
Oct 2, 2023

Conversation

imrannayer
Copy link
Collaborator

No description provided.

@imrannayer imrannayer requested a review from a team as a code owner October 2, 2023 13:38
g-awmalik
g-awmalik approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Minor nit on the format for defining versions.

modules/private-service-connect/versions.tf Outdated Show resolved Hide resolved
modules/private-service-connect/versions.tf Outdated Show resolved Hide resolved
modules/routes-beta/versions.tf Outdated Show resolved Hide resolved
modules/vpc-serverless-connector-beta/versions.tf Outdated Show resolved Hide resolved
@imrannayer imrannayer merged commit 22736f5 into terraform-google-modules:master Oct 2, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Oct 2, 2023
Merged
@imrannayer imrannayer self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imrannayer @g-awmalik