feat: Add service_directory_registrations: namespace and service_directory_region

[sanadhis]

Hi, I would propose to add optional variable of project_region for this module.

The idea is to allow specifying custom, not in us-central1, namespace link.

[imrannayer]

@sanadhis thx for the PR. Can you plz add two optional variables

service_directory_region
service_directory_namespace

and use dynamic blocks if any of these values are provided.

[sanadhis]

Hi @imrannayer thanks for the feedback!

I've addressed them, can you re-review? Thanks 😄

[sanadhis]

Hi @imrannayer can we merge here if it's all okay? thanks 😄

[imrannayer]

@sanadhis Lint test is failing. Can u plz fix it?

[imrannayer]

@sanadhis can u plz follow this doc to fix the linit issues?

[sanadhis]

@sanadhis can u plz follow this doc to fix the linit issues?

thanks for the hint @imrannayer
Lint test passes in my machine now:

...
terraform_validate ./test/fixtures/simple_project_with_regional_network
Success! The configuration is valid.

terraform_validate ./test/fixtures/submodule_firewall
Success! The configuration is valid.

terraform_validate ./test/setup
Success! The configuration is valid.

ENABLE_BPMETADATA not set to 1. Skipping metadata validation.

[imrannayer]

/gcbrun

[imrannayer]

/gcbrun

[imrannayer]

@sanadhis this feature was part of 5.8. Can you plz update version.tf file to use provider version >= 5.8?
This will make it a breaking change. Can you also add a file with details in docs directory.

Thanks

[imrannayer]

/gcbrun

[imrannayer]

/gcbrun

[sanadhis]

@imrannayer should I update modules/private-service-connect/metadata.yaml and provider_meta in modules/private-service-connect/versions.tf or do you have automation when releasing this module?

[imrannayer]

@sanadhis thats not needed. version meta will update by release scripts

[imrannayer]

/gcbrun

[stanimprover]

@sanadhis @imrannayer I'm getting an Unsupported block type Error for the dynamic "service_directory_registrations" for the private-service-connect module and I have changed to multiple versions and still not working. Are you having this issue as well?

[imrannayer]

@stanimprover can u plz create an issue. This is part of 9.1 which is not released yet. Can you also post the code you are using for your testing?