Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change serverless-connector input type and update metadata #568

Merged
merged 4 commits into from
Aug 14, 2024
Merged

feat: Change serverless-connector input type and update metadata #568

merged 4 commits into from
Aug 14, 2024

Conversation

q2w
Copy link
Contributor

@q2w q2w commented Aug 6, 2024 •
edited
Loading

This PR makes below changes,

  1. Updates input variable type for vpc_connectors from list(map(string)) to list(object({}))
  2. Updates metadata

@q2w q2w requested a review from bharathkkb August 6, 2024 19:16
@q2w
Copy link
Contributor Author

q2w commented Aug 8, 2024

/gcbrun

@q2w q2w force-pushed the feature/serverless-connector-input branch from 5c2add3 to c2ceaec Compare August 9, 2024 07:15
@q2w q2w marked this pull request as ready for review August 11, 2024 13:40
@q2w q2w requested review from imrannayer and a team as code owners August 11, 2024 13:40
bharathkkb
bharathkkb approved these changes Aug 12, 2024
View reviewed changes
modules/vpc/metadata.yaml Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit 830b09c into terraform-google-modules:master Aug 14, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q2w @bharathkkb