From e0be39ef8e51907086d99a2564d7c1e20e7df430 Mon Sep 17 00:00:00 2001 From: Steven Hill <58576896+geryonghost@users.noreply.github.com> Date: Tue, 19 Nov 2024 12:52:05 -0600 Subject: [PATCH 1/2] feat: add no_wrapper settings in push_config --- README.md | 2 ++ main.tf | 7 +++++++ 2 files changed, 9 insertions(+) diff --git a/README.md b/README.md index e5333f1..adfe245 100644 --- a/README.md +++ b/README.md @@ -35,6 +35,8 @@ module "pubsub" { minimum_backoff = "300s" // optional filter = "attributes.domain = \"com\"" // optional enable_message_ordering = true // optional + no_wrapper = false // optional + write_metadata = false // optional } ] pull_subscriptions = [ diff --git a/main.tf b/main.tf index 45755f7..50e31de 100644 --- a/main.tf +++ b/main.tf @@ -232,6 +232,13 @@ resource "google_pubsub_subscription" "push_subscriptions" { x-goog-version = lookup(each.value, "x-goog-version", "v1") } + dynamic "no_wrapper" { + for_each = (lookup(each.value, "no_wrapper", true) ? [true] : []) + content { + write_metadata = lookup(each.value, "write_metadata", true) + } + } + dynamic "oidc_token" { for_each = (lookup(each.value, "oidc_service_account_email", "") != "") ? [true] : [] content { From bf555a71aec8be169bf13e6716f320814eb1425b Mon Sep 17 00:00:00 2001 From: Steven Hill <58576896+geryonghost@users.noreply.github.com> Date: Tue, 19 Nov 2024 14:16:10 -0600 Subject: [PATCH 2/2] blank --- main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.tf b/main.tf index 50e31de..fa36ab6 100644 --- a/main.tf +++ b/main.tf @@ -237,7 +237,7 @@ resource "google_pubsub_subscription" "push_subscriptions" { content { write_metadata = lookup(each.value, "write_metadata", true) } - } + } dynamic "oidc_token" { for_each = (lookup(each.value, "oidc_service_account_email", "") != "") ? [true] : []