Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the overall interface/functionality of the module #136

Open
aaaaahaaaaa opened this issue Nov 7, 2024 · 0 comments
Open

Improve the overall interface/functionality of the module #136

aaaaahaaaaa opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@aaaaahaaaaa
Copy link

TL;DR

Quick feedback that I generally find the interface of the module weirdly designed and not particularly useful in its current state. In particular the fact the modules shares the same config for multiple accounts. And the module should also support IAM policies.

I think the following interface would be a lot more useful:

module "service_accounts" {
  project = local.project

  service_accounts = {

    "service-account-a": {
      display_name = "Service Account A"
      generate_key = true,
      roles        = [
        "roles/bigquery.dataEditor",
        "roles/storage.admin",
      ]
      policies = {
        "roles/iam.workloadIdentityUser" = [...]
      }
    },

    "service-account-b": {
      display_name = "Service Account B",
      roles = [
        "roles/bigquery.dataEditor",
        "roles/storage.admin",
      ],
      policies = {
        "roles/iam.workloadIdentityUser" = [...]
      }
    },

  }
}

Terraform Resources

No response

Detailed design

No response

Additional information

No response

@aaaaahaaaaa aaaaahaaaaa added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant