Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add new output account_details, output type and metadata.display.yaml #133

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Oct 16, 2024

This PR makes below changes,

  1. Adds new output account_details. fix: Update the format of "id" output in the "simple-sa" module #123 updated output id. This new account_details output takes place of earstwhile id output which is used by ADC.
  2. Adds metadata.display.yaml for modules/simple-sa
  3. Updates metadata.yaml and adds output type for modules/simple-sa

BEGIN_COMMIT_OVERRIDE
fix: Add new output account_details, output type and metadata.display.yaml (#133)
END_COMMIT_OVERRIDE

@q2w q2w marked this pull request as ready for review October 16, 2024 07:41
@q2w q2w requested a review from a team as a code owner October 16, 2024 07:41
@q2w q2w requested a review from apeabody October 16, 2024 07:41
Copy link

@qz267 qz267 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@q2w q2w merged commit 2a5adbf into terraform-google-modules:master Oct 22, 2024
4 checks passed
@apeabody apeabody added the release-please:force-run Force release-please to check for changes. label Oct 25, 2024
@release-please release-please bot removed the release-please:force-run Force release-please to check for changes. label Oct 25, 2024
@apeabody apeabody added the release-please:force-run Force release-please to check for changes. label Oct 25, 2024
@release-please release-please bot removed the release-please:force-run Force release-please to check for changes. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants