From 2d0e507ae3829ca54e2ec2f0d5fe5a717b61c0e8 Mon Sep 17 00:00:00 2001
From: Abhishek Tiwari <abhiwa@google.com>
Date: Fri, 22 Nov 2024 07:15:09 +0000
Subject: [PATCH] fix: add deletion_protection to backup module and set it to
 false in intergration tests

---
 examples/postgresql-backup-provided-service-account/main.tf | 1 +
 modules/backup/README.md                                    | 1 +
 modules/backup/main.tf                                      | 1 +
 modules/backup/metadata.yaml                                | 6 +++++-
 modules/backup/variables.tf                                 | 6 ++++++
 modules/backup/versions.tf                                  | 2 +-
 6 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/examples/postgresql-backup-provided-service-account/main.tf b/examples/postgresql-backup-provided-service-account/main.tf
index fd18b856..e34c76e4 100644
--- a/examples/postgresql-backup-provided-service-account/main.tf
+++ b/examples/postgresql-backup-provided-service-account/main.tf
@@ -70,6 +70,7 @@ module "backup" {
   service_account             = "${data.google_project.test_project.number}-compute@developer.gserviceaccount.com"
   create_notification_channel = false
   notification_channels       = [google_monitoring_notification_channel.email.id]
+  deletion_protection         = false
 }
 
 data "google_project" "test_project" {
diff --git a/modules/backup/README.md b/modules/backup/README.md
index 8c5d238d..b12be0f4 100644
--- a/modules/backup/README.md
+++ b/modules/backup/README.md
@@ -60,6 +60,7 @@ fetch workflows.googleapis.com/Workflow
 | compress\_export | Whether or not to compress the export when storing in the bucket; Only valid for MySQL and PostgreSQL | `bool` | `true` | no |
 | connector\_params\_timeout | The end-to-end duration the connector call is allowed to run for before throwing a timeout exception. The default value is 1800 and this should be the maximum for connector methods that are not long-running operations. Otherwise, for long-running operations, the maximum timeout for a connector call is 31536000 seconds (one year). | `number` | `1800` | no |
 | create\_notification\_channel | If set to true it will create email notification channel | `bool` | `false` | no |
+| deletion\_protection | Whether Terraform will be prevented from destroying the workflow. | `bool` | `true` | no |
 | enable\_backup\_monitoring | Whether to monitor backup workflows or not | `bool` | `false` | no |
 | enable\_connector\_params | Whether to enable connector-specific parameters for Google Workflow SQL Export. | `bool` | `false` | no |
 | enable\_export\_backup | Weather to create exports to GCS Buckets with this module | `bool` | `true` | no |
diff --git a/modules/backup/main.tf b/modules/backup/main.tf
index d590738d..bd516779 100644
--- a/modules/backup/main.tf
+++ b/modules/backup/main.tf
@@ -99,6 +99,7 @@ resource "google_workflows_workflow" "sql_backup" {
     backupRetentionTime      = var.backup_retention_time
     backupRunsListMaxResults = var.backup_runs_list_max_results
   })
+  deletion_protection = var.deletion_protection
 }
 
 resource "google_cloud_scheduler_job" "sql_backup" {
diff --git a/modules/backup/metadata.yaml b/modules/backup/metadata.yaml
index 5198a9fe..ad41812b 100644
--- a/modules/backup/metadata.yaml
+++ b/modules/backup/metadata.yaml
@@ -27,7 +27,7 @@ spec:
       dir: /modules/backup
     actuationTool:
       flavor: Terraform
-      version: ">= 0.13"
+      version: ">= 1.3"
     description: {}
   content:
     examples:
@@ -89,6 +89,10 @@ spec:
         description: If set to true it will create email notification channel
         varType: bool
         defaultValue: false
+      - name: deletion_protection
+        description: Whether Terraform will be prevented from destroying the workflow.
+        varType: bool
+        defaultValue: true
       - name: enable_backup_monitoring
         description: Whether to monitor backup workflows or not
         varType: bool
diff --git a/modules/backup/variables.tf b/modules/backup/variables.tf
index 84d4bcf7..598495c5 100644
--- a/modules/backup/variables.tf
+++ b/modules/backup/variables.tf
@@ -192,3 +192,9 @@ variable "notification_channels" {
   type        = list(string)
   default     = []
 }
+
+variable "deletion_protection" {
+  description = "Whether Terraform will be prevented from destroying the workflow."
+  type        = bool
+  default     = true
+}
diff --git a/modules/backup/versions.tf b/modules/backup/versions.tf
index 8fbfeba7..17f8db96 100644
--- a/modules/backup/versions.tf
+++ b/modules/backup/versions.tf
@@ -19,7 +19,7 @@ terraform {
   required_providers {
     google = {
       source  = "hashicorp/google"
-      version = ">= 4.0, < 7"
+      version = ">= 6.11, < 7"
     }
   }
 }