feat(TF>=1.3)!: make mig health check fields optional #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-awmalik
requested changes
Feb 25, 2024
There was a problem hiding this comment.
Thanks for the PR. Looks fine overall but needs a bump to the required_version for Terraform to >= 1.3.
|
/gcbrun |
g-awmalik
changed the title
g-awmalik
changed the title
|
@rauny-brandao - I just realized that you haven't added any assertions for the healthcheck example that you modified. Can you please take a moment and add them here? |
|
is there something missing for this to be merged @apeabody & @g-awmalik?! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes MIG health check fields optional, the default values comes from the variable
health_check, closes #153