Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement function for managing VPC Service Controls #16

Merged
merged 17 commits into from
Sep 23, 2019
Merged

Implement function for managing VPC Service Controls #16

merged 17 commits into from
Sep 23, 2019

Conversation

morgante
Copy link
Contributor

@morgante morgante commented Sep 17, 2019 •
edited
Loading

Fixes #11

TODO:

  • Add support for projects being moved OUT of a folder
  • Use Cloud Functions service account instead of cred file
  • Fix ACM race condition (acm access levels are in pending state on VPC service control creation)

Nice to have:

  • Add tests
  • Failure notifications
  • Switch to a native Go library to make terraform a native dependency
  • Retries for cloud function
  • Add support for subfolders
  • Reduce function code zip file
  • Possibly simplify whole approach

@morgante morgante mentioned this pull request Sep 17, 2019
Open
7 tasks
@aaron-lane aaron-lane added the enhancement New feature or request label Sep 19, 2019
nick4fake and others added 3 commits September 20, 2019 15:54
@nick4fake @morgante
Fixes #11: Cloud Function for automatic folder inclusion
dc50277 
#11
#14

Added example with cloud function that automatically runs TF when
project is created/moved/deleted.
@morgante
Make backend sample more robust
c2d313c
@morgante
Work on instructions
17e36fa
@morgante morgante force-pushed the feature/folder-function branch from 1cb6b95 to 17e36fa Compare September 20, 2019 19:54
@morgante morgante merged commit aec19d7 into master Sep 23, 2019
@aaron-lane aaron-lane deleted the feature/folder-function branch December 10, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud Function for automatic folder inclusion
3 participants
@morgante @aaron-lane @nick4fake