fix: Complete Schematics migration cleanup and add comprehensive tests

[daniel-butler-irl]

Description

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[whoffler]

Instead of passing logger should we use CloudInfoService.Logger ?

[whoffler]

Many functions in cloudinfo/schematics.go that take logger as a parameter

[whoffler]

think this is no longer used

replaced by https://github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper/pull/1063/files#diff-0b9e30ab0684c4cb2c12680894f5fe6208a37cf096d1ae19cf647d42ee582cc3R26

[whoffler]

schematics authenticates using the infoSvc.authenticator.RequestToken() which replaces the svc.ApiAuthenticator.RequestToken() call. They seem to be making the same call, could there be something in the order of calls that affects this?

We're getting:

---

Update:
Think I see the difference... we need to update the authenticator

svc.ApiAuthenticator = &core.IamAuthenticator{
		ApiKey: ibmcloudApiKey,
		ClientId:     "bx", // missing from cloudinfo authenticator
		ClientSecret: "bx", // missing from cloudinfo authenticator
	}

---

Update:

Tested update to cloudInfo authenticator adding ClientId and ClientSecret and have passing schematics tests

[daniel-butler-irl]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.60.23 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀