[Bug]: Can't connect to server (...YabnElement.isNull()... error)

[WimpieRatte]

Bug Description

Minecraft 1.20.1

Just in case this is not a Heracles issue, I logged this matter with ResourcefulLib as well: Team-Resourceful/ResourcefulLib#13

Error message:

People are unable to join after they were in the first time.

Log is attached.

One way I found that clears it, is if I stop the server, then delete the data/heracles* files in the world and then start the server.
But then the same thing happens all over again.

How to Reproduce?

1. Install "Colonies and Technologies" modpack
2. Start a server version (the following mods will need to be excluded on the server side: Panorama Screens, Footprint Particle, Embeddium, watermedia, better beds reforged, BiomeParticleWeather, cherished worlds, clean tooltips, completionist index, current game music track, distinguished potions, effect descriptions, equipment compare, essential, forgematica, helditemtooltips, improved sign editing, loading backgrounds, mafglib, mob plaques, modpack update checker, no resourcepack warnings, overflowing bars, seamless, slot cycler, splashy, trade uses, traveler's titles, WI Zoom, yeetus experimentus)
3. Join the server (first time should be fine)
4. Complete some quests and exit
5. Try to rejoin

Expected Behavior

Be able to log into the server.

Version

1.1.12

Mod Loader Version

1.20.1 - 47.2.30

Mod Loader

Forge

Logs or additional context

latest.log

Code of Conduct

• I have searched the issue tracker and confirmed that the issue has not been reported
• I have checked the FAQ (if one is present) and my issue is not listed
• I have verified that I am using the latest version of the mod
• I have verified that I have installed all the required dependencies for the mod
• I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.

[SubordinalBlue]

Wow...line 5088 looks massive.

5088-[13May2024 19:46:57.758] [Netty Client IO #1/ERROR] [earth.terrarium.heracles.Heracles/]: Failed to decode sync quests packet: <large YabnObject follows...>

[WimpieRatte]

I'm currently trying to unload all quests and load them back one section at a time to try and pinpoint why this happens.
But it's a very slow grind, because I have over 200 files in my heracles config folder.

Also, this issue does not happen when inviting friends via the Essential mod to a single player world.
Only on dedicated servers.

[WimpieRatte]

Latest details from Discord chat:
SubordinalBlue — Today at 1:50 AM

random idea... does your client already have the exact same quest files as the server?

wRatte — Today at 1:51 AM

I tried that in the beginning and when I noticed that it takes the server's quest files, I stopped trying to update the client.
When I had my "main" quests loaded on the server and only the welcome quest on the client, it worked.
but then when I added the "main" quests back in the client - it errored again.

[ThatGravyBoat]

Looking at it, its because of a null yabnelement which is a valid yabn element this is an underlying issue with how I wrote yabnops to mimic jsonops in DFU Mojang/DataFixerUpper#62 ill have to figure out a workaround the issue seems to be that the nbt fields are not there so they default to null so a quick way would be to add empty object nbt fields

[ThatGravyBoat]

Fixed in latest resourcefullib version