Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip button, volume button, options menu & more videos popup aren't accurate. #1

Open
kwan-vini opened this issue Oct 12, 2023 · 3 comments

Comments

@kwan-vini
Copy link

These ones are probably a bit too obvious...
image
image

Skip icon is supossed to have 2 triangles instead a normal one.
image
image

Volume icons looks material-like (also it doesen't show the little "sound ripples").
image
image

@tersiswilvin
Copy link
Owner

Hi, the settings panel was left alone due to multiple issues I ran into in the past that wouldn't make it 1:1 with the one used in the past. The next popup was left alone by mistake as I had missed it at the time, I'll make sure to remove it when I can. The skip button used is accurate to the one used in late 2012 via the spritesheet, the one you're talking about with the double triangle is the skip button used around in the 2013/2014 html5 player. Lastly the volume icon is the one used in the late 2012 player not sure how it looks material like unless you're talking about the slider, however I believe the "sound ripple" not showing is likely because youtube changed the arial text used in the language you used which no longer shows the icon anymore which I'll look into.

@kwan-vini
Copy link
Author

Hi, the settings panel was left alone due to multiple issues I ran into in the past that wouldn't make it 1:1 with the one used in the past. The next popup was left alone by mistake as I had missed it at the time, I'll make sure to remove it when I can. The skip button used is accurate to the one used in late 2012 via the spritesheet, the one you're talking about with the double triangle is the skip button used around in the 2013/2014 html5 player. Lastly the volume icon is the one used in the late 2012 player not sure how it looks material like unless you're talking about the slider, however I believe the "sound ripple" not showing is likely because youtube changed the arial text used in the language you used which no longer shows the icon anymore which I'll look into.

Thanks for replying. About the skip button, will you integrate the double-triangle design as a setting in the userstyle? That would maybe make it more accurate if anyone wanted to have a 2013-like player. Also i totally was wrong saying the volume icon was "material-like". For some reason i thought the icon was more "squished" but it's just a matter of pixels, really. Anyways, i hope the next update is going to add such features. Don't stress yourself about it, hydrate yourself, and have a good day!

Your userstyle is awesome <3

@tersiswilvin
Copy link
Owner

tersiswilvin commented Oct 19, 2023

Hi, the settings panel was left alone due to multiple issues I ran into in the past that wouldn't make it 1:1 with the one used in the past. The next popup was left alone by mistake as I had missed it at the time, I'll make sure to remove it when I can. The skip button used is accurate to the one used in late 2012 via the spritesheet, the one you're talking about with the double triangle is the skip button used around in the 2013/2014 html5 player. Lastly the volume icon is the one used in the late 2012 player not sure how it looks material like unless you're talking about the slider, however I believe the "sound ripple" not showing is likely because youtube changed the arial text used in the language you used which no longer shows the icon anymore which I'll look into.

Thanks for replying. About the skip button, will you integrate the double-triangle design as a setting in the userstyle? That would maybe make it more accurate if anyone wanted to have a 2013-like player. Also i totally was wrong saying the volume icon was "material-like". For some reason i thought the icon was more "squished" but it's just a matter of pixels, really. Anyways, i hope the next update is going to add such features. Don't stress yourself about it, hydrate yourself, and have a good day!

Your userstyle is awesome <3

I was hoping to integrate 2013+ html5 player options when I get the rewrite finished which would introduce 2011 to early/mid 2015 html5 players, however since I had haulted progress on it to focus on my other theme and also because of the things going on in my life I am unable to know when the rewrite will be finished. I may look into adding 2013 icons if I don't see any progress made on the rewrite within the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants