Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 - Seeing 10s minimum time for all cache restores #43

Closed
alexellis opened this issue Feb 20, 2024 · 3 comments · Fixed by #44
Closed

🐛 - Seeing 10s minimum time for all cache restores #43

alexellis opened this issue Feb 20, 2024 · 3 comments · Fixed by #44
Labels
bug Something isn't working

Comments

@alexellis
Copy link

alexellis commented Feb 20, 2024

Describe the bug

Hi, @welteki has been trying out this action for self-hosted runners. It seems like every time a restore is done, even for 1MB from a local network using Minio or Seaweedfs, there's a 10s minimum penalty.

For the same amount of data, GitHub's hosted cache can be as little as a second or lower.

To Reproduce

Simply use the action, configured with S3 over the same LAN where the self-hosted runner is running.

Expected behavior

Faster, or as fast as GitHub's hosted cache.

Screenshots

Local cache with testpkg/actions-cache:

Bundler cache - 273.39MB, 11s
Yarn cache - 454.25MB, 11s
Plugins gems cache - 53.85MB, 10s
App state cache - 1.4MB, 10s

GitHub cache on self-hosted runner:

Bundler cache - 261MB, 13s (high 20s)
Yarn cache - 433MB, 18s (high 24s)
Plugins gems cache - 51MB, 3s
App state cache - 1MB, 2s

GitHub's cache on hosted runner:

Bundler cache - 261MB, 6s
Yarn cache - 434MB, 11s
Plugins gems cache - 51MB, 3s
App state cache - 1MB, 2s

Code/Script reproduction

Perhaps @welteki can paste in a minimal example here?

Additional context

Feel free to ask for additional context if there's anything that would help?

@alexellis alexellis added the bug Something isn't working label Feb 20, 2024
@jackieli-tes
Copy link
Contributor

can you enable verbose logging and share the actions log?

In our setup, the restoring is under 3 seconds even for caches > 1GB

@welteki
Copy link
Contributor

welteki commented Feb 20, 2024

Hi @jackieli-tes

I identified the cause of the issue we were seeing here and opened a PR with a fix. #44

@jackieli-tes
Copy link
Contributor

@welteki Thanks for the issue and the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants