Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have two different packages for Hspec and Tasty #19

Open
michivi opened this issue Oct 10, 2022 · 3 comments
Open

Have two different packages for Hspec and Tasty #19

michivi opened this issue Oct 10, 2022 · 3 comments

Comments

@michivi
Copy link
Contributor

michivi commented Oct 10, 2022

Question

Would it be possible to have two different packages, one for Hspec and one for Tasty?

Currently, when one chooses to use Hspec (resp. Tasty), they also have to compile Tasty (resp. Hspec) as testcontainers-hs uses both as dependencies. But they won't actually use it.

Perhaps having something like this could help:

  • The testcontainers-hs-core package would have all the definitions required to use testcontainers-hs, whether we're a Hspec user or Tasty user.
  • The testcontainers-hs-hspec package for Hspec users
  • The testcontainers-hs-tasty package for Tasty users

Do you think something like that would be doable?
Thanks in any case 🙂

@alexbiehl
Copy link
Collaborator

Sure definitely doable. Happy to accept contributions. But my question is, does it really matter? Compiling dependencies is a one time thing, no?

@michivi
Copy link
Contributor Author

michivi commented Oct 11, 2022

Right, but it still feels unnecessary to build tasty and its dependencies when we're using hspec. In CI, we would also use unnecessary storage for the compiled binary, though surely not significantly to be important. In any case, I guess this sure sounds low-priority as nothing is broken. If I have time, I'll try to tackle it 🙂

@alexbiehl
Copy link
Collaborator

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants