Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope of project? (blob queues, azure file, etc.) #3

Open
Jerph opened this issue Sep 25, 2024 · 1 comment
Open

Scope of project? (blob queues, azure file, etc.) #3

Jerph opened this issue Sep 25, 2024 · 1 comment

Comments

@Jerph
Copy link

Jerph commented Sep 25, 2024

Great work on the new gem!

I'm using a forked version of azure-storage-file, but there doesn't seem to be anyone whose taking up the mantle of actually maintaining a fork, or a creating a ground-up version as you've done.

Do you intend to expand this library to cover other Azure Storage functionality (particularly Azure File)? The managed identity code would apply. Maybe separate libraries in a shared codebase like the original azure-storage-ruby repo?

Thanks!

@JoeDupuis
Copy link
Member

Thank you! I missed this as I was traveling for Rails World.

I wanted to keep this gem Blob specific. I wrote it mainly to support Active Storage.
A clone of this Gem for Azure file could make sense and would probably be easy to write.
I don't think it's necessary to extract code as a shared dependency. There would be code duplication, but

  • the gems would be decoupled
  • the code is pretty light, the duplication is not be significant.
  • the API is stable, I don't think we'll have to patch this code often.

Though, it means querying for two access token when both gems are installed. I don't think it would be a problem, since the tokens are not refreshed often, but I am not sure what the rate limit is, it could be an issue on app startup.

I am not dead set on this, I could change my mind, but I don't think I would work on this soon either way. I am already working on a couple other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants