-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify "Firing Events" page #490
Comments
I'm up for this one :) |
Hi @afontcu, @kentcdodds. Do you think a reference to this app or maybe even gathering up this to an example page is worth doing within this task? Also, do you think we should build a "General"/"Universal" section? Or do you think it's related to "Getting Started"? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think we're ready to start getting PRs ready to document user event as an official export to Most of the docs from the original repo can be copied, but there are some improvements I think we should make:
Off the top of my head, here are some of the differences (though someone should probably do an accuracy check with the PR testing-library/dom-testing-library#616):
I'm sure there are things I'm missing, but if someone could get this started, that would be phenomenal! |
This comment has been minimized.
This comment has been minimized.
Thanks, Kent! That's great news.
Totally agree. If possible, all code examples in docs should be based on "real" components, instead of
I gotta say this makes me extremely happy – one less difference to worry about between React Testing Lib and Vue Testing Lib ❤️ I wonder if docs should still mention |
@nickmccurdy, only bug fixes will go into user-event for the next little while. No new features or even improvements to "correctness". @afontcu, I agree. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ok, so it looks like |
Hopefully it will get merged, but for now it looks like @jacobparis have done some work on this in his PR #502, let's just try to keep them aligned with all the other "universal" work we're doing in #489 and #485 |
@alexkrolick I think we can close this one also after #735 was merged, wdyt? |
Same thing as #485.
Event firing utilities are mostly "universal", so they could live above DTL docs.
The text was updated successfully, but these errors were encountered: