Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages #34

Open
marcosvega91 opened this issue May 28, 2020 · 5 comments
Open

Add packages #34

marcosvega91 opened this issue May 28, 2020 · 5 comments

Comments

@marcosvega91
Copy link
Member

marcosvega91 commented May 28, 2020

The project step by step will grow and could have in the next future more packages:

  1. site with embed
  2. chrome extension
  3. devtools extension

We should think to add something similar to lerna to manage all of them

@aganglada
Copy link
Collaborator

@marcosvega91 NPM released workspaces a few weeks ago, I can. spend some time giving it a shot, would you like me to do so? https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/

@smeijer
Copy link
Member

smeijer commented Nov 11, 2020

@aganglada, can you tell me what the impact is for contributions/maintainers?

@aganglada
Copy link
Collaborator

@smeijer Depends of what you mean with impact, but basically:

  • We will structure the repo in different packages app, chrome-extension, devtools
  • We will need to change contributing guidelines so they follow the new structure
  • Change on documentation
  • Change on github actions to make sure it all works like it does currently.

Is that what you mean?

@smeijer
Copy link
Member

smeijer commented Nov 12, 2020

Thanks,

That. And also; once it has been restructured. What do I need to do to install a package into devtools, and what do I need to install it into app?

But please, feel free to give it a shot. It would be much appreciated. ❤️

@aganglada
Copy link
Collaborator

@smeijer yep, that will be something like npm workspace app add your-package. I will investigate 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants