From 59566fe85dacbe7aa7d988e9ee553809dbcfb043 Mon Sep 17 00:00:00 2001 From: Testo Nakada Date: Sun, 1 Nov 2015 08:21:48 -0800 Subject: [PATCH] Performance improvement by fixing hashCode() to include m_instance.hashCode() --- src/main/java/org/testng/internal/BaseTestMethod.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/testng/internal/BaseTestMethod.java b/src/main/java/org/testng/internal/BaseTestMethod.java index 5a787c3f6c..203988fdea 100755 --- a/src/main/java/org/testng/internal/BaseTestMethod.java +++ b/src/main/java/org/testng/internal/BaseTestMethod.java @@ -70,7 +70,7 @@ public abstract class BaseTestMethod implements ITestNGMethod { private int m_priority; private XmlTest m_xmlTest; - private Object m_instance; + private final Object m_instance; /** * Constructs a BaseTestMethod TODO cquezel JavaDoc. @@ -428,7 +428,11 @@ public boolean equals(Object obj) { */ @Override public int hashCode() { - return m_method.hashCode(); + int hash = m_method.hashCode(); + if (m_instance != null) { + hash = hash * 31 + m_instance.hashCode(); + } + return hash; } protected void initGroups(Class annotationClass) {