WIP: Trying to promote const local array using GVN pass#5
Closed
WIP: Trying to promote const local array using GVN pass#5
Conversation
tesuji
commented
Jun 12, 2024
| // [255, 105, 15, 39, 62, 251, 191, 178, 9, 4, 56, 221], | ||
| // [193, 164, 194, 197, 6, 243, 218, 171, 87, 247, 104, 42], | ||
| // ]; | ||
| let _darr = *&[ |
Owner
Author
There was a problem hiding this comment.
This returns Some(OpTy { op: Indirect(MemPlace { ptr: alloc2<imm>, meta: None, misaligned: None }), ty: [i32; 32] })
tesuji
commented
Jun 12, 2024
| // CHECK: let [[array_lit:_.*]]: [i32; 32]; | ||
| // CHECK: debug _arr => [[arr:_.*]]; | ||
|
|
||
| let _arr = [ |
Owner
Author
There was a problem hiding this comment.
With commits[3], this now returns as a immutable memplace: Some(OpTy { op: Indirect(MemPlace { ptr: alloc3<imm>, meta: None, misaligned: None }), ty: [i32; 32] }).
But in the mir diff, _arr still is not promoted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewriting of rust-lang#125916 which used PromoteTemps pass.
Current status
commits[1..]doesn't change the test diff.I'm trying to returnThat is not enough to promote the array.OpTy { op: Indirect(MemPlace { .. }), ty: [i32; 32] }foreval_to_const(array). Becauseeval_to_const(*&array)is returning a similiar value.