Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tags are not highlighted in CSS #17

Open
bobrovnikov opened this issue Jan 20, 2015 · 3 comments
Open

Some tags are not highlighted in CSS #17

bobrovnikov opened this issue Jan 20, 2015 · 3 comments

Comments

@bobrovnikov
Copy link

While reading through CSS file I noticed that svg tag was not colored as others: https://github.com/h5bp/html5-boilerplate/blob/master/src/css/main.css#L58
screenshot from 2014-12-23 15 07 25

It seems that svg is missing in this regular expression: https://github.com/textmate/css.tmbundle/blob/master/Syntaxes/CSS.plist#L711, unlike audio and canvas, which are present there and are colored green as well.

It would be good to compare existing regular expression against a credible list like this: https://developer.mozilla.org/en-US/docs/Web/HTML/Element

However, HTML5 allows the creation of custom elements: http://www.html5rocks.com/en/tutorials/webcomponents/customelements/. In this case shall we have a discussion of whether to:

  • complete the list with missing tags or
  • make a new regular expression to adjust to custom tags?
@carlsmith
Copy link

The same issue comes up with main. There's an example here.

@dstorey
Copy link

dstorey commented Jan 11, 2016

I have a fix for this and other properties in a PR for VS Code. Once that is merged, I'll look to doing a PR here to keep in sync.

@hausofwong
Copy link
Contributor

I'm happy to have a look at this.

If we're adding svg to the element list, do we need to add all the SVG elements as well? I do a lot of SVG styling through my CSS stylesheets and it would be nice, but not too sure if it's overkill.

Full list can be found here: https://developer.mozilla.org/en-US/docs/Web/SVG/Element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants