Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] @namespace is not syntax highlighted #24

Open
aeschli opened this issue Jan 8, 2016 · 1 comment
Open

[css] @namespace is not syntax highlighted #24

aeschli opened this issue Jan 8, 2016 · 1 comment

Comments

@aeschli
Copy link

aeschli commented Jan 8, 2016

From @dstorey on December 26, 2015 10:43

Works correctly in the parser for linting and in Intellisense, but isn't syntax highlighted as missing from css.plist

screen shot 2015-12-26 at 2 37 41 am

Syntax should be:

namespace
: NAMESPACE_SYM S* [namespace_prefix S_]? [STRING|URI] S_ ';' S*
;
namespace_prefix
: IDENT
;

My knowledge of the syntax of css.plist and regexp isn't good enough at the moment to work out how to add the optional IDENT, as there is no predefined ident like there is for strings, etc. I know how to highlight the @namespace and string component though.

I figure the IDENT should be coloured the same as @namespace as that is how the media type token is coloured for '@media media-type'

Copied from original issue: microsoft/vscode#1659

@aeschli
Copy link
Author

aeschli commented Jan 8, 2016

From @dstorey on December 26, 2015 17:18

IDENT is also needed for @Keyframes, so would be good to add it in a way that can be reused, rather than defining it twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant